--chore(ci_visibility): decouple EFD faulty session from is_new

ddtrace/internal/ci_visibility/api/_test.py

@@ -129,18 +129,8 @@ def _set_item_tags(self) -> None:
     def _set_known_tests_tags(self) -> None:
         # NOTE: The `is_new` tag is currently being set in the context of:
         # - Known tests enabled
-        # - EFD
-        if not self.is_new():
-            return
-
-        session = self.get_session()
-        if session is not None and self._session_settings.efd_settings.enabled:
-            # If a session is considered faulty, we do not want to tag the
-            # test as new.
-            if not session.efd_is_faulty_session():
-                self.set_tag(TEST_IS_NEW, self._is_new)
-
-        elif self._is_known_tests_enabled:
+        # - EFD (subset of known tests)
+        if self._is_known_tests_enabled and self.is_new():
             self.set_tag(TEST_IS_NEW, self._is_new)
 
     def _set_efd_tags(self) -> None:

tests/snapshots/test_api_fake_runners.test_manual_api_fake_efd_faulty_session.json

@@ -46,6 +46,7 @@
       "test.command": "manual_efd_faulty_session",
       "test.framework": "dd_manual_test_fw",
       "test.framework_version": "1.0.0",
+      "test.is_new": "true",
       "test.module": "m1",
       "test.module_path": "",
       "test.name": "m1_s1_t1",
@@ -118,6 +119,7 @@
       "test.command": "manual_efd_faulty_session",
       "test.framework": "dd_manual_test_fw",
       "test.framework_version": "1.0.0",
+      "test.is_new": "true",
       "test.module": "m1",
       "test.module_path": "",
       "test.name": "m1_s1_t2",
@@ -781,6 +783,7 @@
       "test.command": "manual_efd_faulty_session",
       "test.framework": "dd_manual_test_fw",
       "test.framework_version": "1.0.0",
+      "test.is_new": "true",
       "test.module": "m2",
       "test.module_path": "",
       "test.name": "m2_s1_t0",
@@ -850,6 +853,7 @@
       "test.command": "manual_efd_faulty_session",
       "test.framework": "dd_manual_test_fw",
       "test.framework_version": "1.0.0",
+      "test.is_new": "true",
       "test.module": "m2",
       "test.module_path": "",
       "test.name": "m2_s1_t1",