Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): decouple EFD faulty session from is_new #13062

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Apr 4, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

tests/snapshots/test_api_fake_runners.test_manual_api_fake_efd_faulty_session.json  @DataDog/apm-python

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

tests/snapshots/test_api_fake_runners.test_manual_api_fake_efd_faulty_session.json  @DataDog/apm-python

Base automatically changed from gnufede/SDTEST-1273-02 to main April 4, 2025 09:32
Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/api/_test.py                             @DataDog/ci-app-libraries
tests/snapshots/test_api_fake_runners.test_manual_api_fake_efd_faulty_session.json  @DataDog/apm-python

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025

Benchmarks

Benchmark execution time: 2025-04-04 09:46:45

Comparing candidate commit 35baba1 in PR branch gnufede/SDTEST-1273-03 with baseline commit 07f3611 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 458 metrics, 2 unstable metrics.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 228 ± 3 ms.

The average import time from base is: 232 ± 4 ms.

The import time difference between this PR and base is: -4.3 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.147 ms (0.94%)
ddtrace.bootstrap.sitecustomize 1.478 ms (0.65%)
ddtrace.bootstrap.preload 1.478 ms (0.65%)
ddtrace.internal.products 1.478 ms (0.65%)
ddtrace.internal.remoteconfig.client 0.688 ms (0.30%)
ddtrace 0.668 ms (0.29%)

update snapshot

update snapshot
@gnufede gnufede force-pushed the gnufede/SDTEST-1273-03 branch from ee43a5b to 5e22b48 Compare April 4, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants