Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ESLint from v8 to v9 #5215

Draft
wants to merge 3 commits into
base: watson/clean-eslint-config
Choose a base branch
from

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 6, 2025

What does this PR do?

Upgrade ESLint to the newest major version (9.19.0 -> 8.57.0)

Motivation

Plugin Checklist

Additional Notes

Copy link
Collaborator Author

watson commented Feb 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson mentioned this pull request Feb 6, 2025
6 tasks
@watson watson self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Overall package size

Self size: 8.63 MB
Deduped: 95.04 MB
No deduping: 95.56 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.7.1 | 96.67 kB | 96.67 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (affdfad) to head (384864d).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           watson/clean-eslint-config    #5215      +/-   ##
==============================================================
+ Coverage                       81.08%   81.12%   +0.03%     
==============================================================
  Files                             474      481       +7     
  Lines                           21363    21448      +85     
==============================================================
+ Hits                            17322    17399      +77     
- Misses                           4041     4049       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: watson/bump-eslint
Commit report: 356643b
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 628 Passed, 0 Skipped, 12m 9.05s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 11:32:28

Comparing candidate commit 384864d in PR branch watson/bump-eslint with baseline commit affdfad in branch watson/clean-eslint-config.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 902 metrics, 26 unstable metrics.

@watson watson force-pushed the watson/clean-eslint-config branch from 41d7bb5 to affdfad Compare February 6, 2025 08:44
@watson watson force-pushed the watson/bump-eslint branch 2 times, most recently from c50c2a6 to d58f5ee Compare February 6, 2025 10:46
@watson watson changed the base branch from watson/clean-eslint-config to watson/enable-eslint-plugin-n February 6, 2025 10:46
@watson watson force-pushed the watson/enable-eslint-plugin-n branch from 2ba81f9 to a00cbf6 Compare February 6, 2025 11:04
@watson watson force-pushed the watson/bump-eslint branch from d58f5ee to 9fc9ec2 Compare February 6, 2025 11:05
@watson watson force-pushed the watson/bump-eslint branch from 9fc9ec2 to 384864d Compare February 6, 2025 11:22
@watson watson changed the base branch from watson/enable-eslint-plugin-n to watson/clean-eslint-config February 6, 2025 11:22
@watson watson mentioned this pull request Feb 6, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant