Clean up ESLint config #5214

watson · 2025-02-06T08:05:14Z

What does this PR do?

Allow the use of Node.js APIs in Node.js v18.0.0 and above
Remove disabled rules that were too agressive (replace with inline ignore comments or fix lint errors)
Scope mocha rules to only apply to test files
Rename package.json script lint-fix to lint:fix
Use modern style of extending imported flat config files
Delete unused .rslintrc.json files
- Nested ESLint config files are not supported with the new flat config file standard
- They should now all be covered by the root eslint.config.mjs file
Name all config groups (useful for debugging)

Motivation

Plugin Checklist

Additional Notes

watson · 2025-02-06T08:05:31Z

ESLint: Require 'use strict' header #5218
Enable recommended rules for eslint-plugin-n #5216
Upgrade ESLint from v8 to v9 #5215
Clean up ESLint config #5214 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-02-06T08:06:06Z

Overall package size

Self size: 8.63 MB
Deduped: 95.03 MB
No deduping: 95.55 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-02-06T08:07:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (f49e6ff) to head (affdfad).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5214      +/-   ##
==========================================
- Coverage   81.12%   81.08%   -0.04%     
==========================================
  Files         481      474       -7     
  Lines       21448    21363      -85     
==========================================
- Hits        17399    17322      -77     
+ Misses       4049     4041       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-datadog-prod-us1 · 2025-02-06T08:07:49Z

Datadog Report

Branch report: watson/clean-eslint-config
Commit report: 245b272
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 630 Passed, 0 Skipped, 16m 5.96s Total Time

watson · 2025-02-06T08:08:12Z

package.json

@@ -117,7 +117,7 @@
  "devDependencies": {
    "@apollo/server": "^4.11.0",
    "@eslint/eslintrc": "^3.1.0",
-    "@eslint/js": "^9.11.1",
+    "@eslint/js": "^8.57.1",


This version of is actually not compatible with the major version of ESLint we use (v8). Once we upgrade to v9, we can upgrade this as well

watson · 2025-02-06T08:08:53Z

packages/dd-trace/test/encode/0.5.spec.js

@@ -35,7 +35,7 @@ describe('encode 0.5', () => {
        example: 1
      },
      start: 123123123123123120,
-      duration: 456456456456456456,
+      duration: 4564564564564564,


Changed because I re-enabled no-loss-of-precision rule

watson · 2025-02-06T08:09:03Z

packages/dd-trace/test/format.spec.js

@@ -60,7 +60,7 @@ describe('format', () => {
        _service: 'test'
      }),
      setTag: sinon.stub(),
-      _startTime: 1500000000000.123456,
+      _startTime: 1500000000000.123,


Changed because I re-enabled no-loss-of-precision rule

pr-commenter · 2025-02-06T08:22:24Z

Benchmarks

Benchmark execution time: 2025-02-06 08:58:47

Comparing candidate commit affdfad in PR branch watson/clean-eslint-config with baseline commit f49e6ff in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 906 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

🟩 max_rss_usage [-115.631MB; -70.657MB] or [-12.042%; -7.358%]

benchmark/sirun/appsec-iast/insecure-bank.js

Overview over changes: - Allow the use of Node.js APIs in Node.js v18.0.0 and above - Remove disabled rules that were too agressive (replace with inline ignore comments or fix lint errors) - Scope mocha rules to only apply to test files - Use modern style of extending imported flat config files - Rename `package.json` script `lint-fix` to `lint:fix` - Delete unused `.rslintrc.json` files - Name all config groups (useful for debugging)

IlyasShabi

LGTM

simon-id · 2025-02-06T13:46:35Z

eslint.config.mjs

+        // Normally setting this in the `package.json` engines field is enough, but when we have more than one active
+        // major release line at the same time, we need to specify the lowest version here to ensure backporting will
+        // not fail.
+        version: '>=18.0.0'


didn't we agree we'd keep v4 "backportable" in case we need to, and thus keep v16.0.0 for now ?

watson requested review from a team as code owners February 6, 2025 08:05

watson force-pushed the watson/clean-eslint-config branch from b294685 to 1134746 Compare February 6, 2025 08:06

watson self-assigned this Feb 6, 2025

watson added the semver-patch label Feb 6, 2025

watson commented Feb 6, 2025

View reviewed changes

watson force-pushed the watson/clean-eslint-config branch from 1134746 to 41d7bb5 Compare February 6, 2025 08:11

watson mentioned this pull request Feb 6, 2025

Upgrade ESLint from v8 to v9 #5215

Draft

6 tasks

IlyasShabi reviewed Feb 6, 2025

View reviewed changes

benchmark/sirun/appsec-iast/insecure-bank.js Show resolved Hide resolved

watson force-pushed the watson/clean-eslint-config branch from 41d7bb5 to affdfad Compare February 6, 2025 08:44

watson mentioned this pull request Feb 6, 2025

Enable recommended rules for eslint-plugin-n #5216

Draft

6 tasks

IlyasShabi approved these changes Feb 6, 2025

View reviewed changes

watson mentioned this pull request Feb 6, 2025

ESLint: Require 'use strict' header #5218

Draft

6 tasks

simon-id reviewed Feb 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up ESLint config #5214

Clean up ESLint config #5214

watson commented Feb 6, 2025 •

edited

Loading

watson commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

codecov bot commented Feb 6, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 6, 2025 •

edited

Loading

watson Feb 6, 2025

watson Feb 6, 2025 •

edited

Loading

watson Feb 6, 2025

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

IlyasShabi left a comment

simon-id Feb 6, 2025

Clean up ESLint config #5214

Are you sure you want to change the base?

Clean up ESLint config #5214

Conversation

watson commented Feb 6, 2025 • edited Loading

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

watson commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

Overall package size

codecov bot commented Feb 6, 2025 • edited Loading

Codecov Report

datadog-datadog-prod-us1 bot commented Feb 6, 2025 • edited Loading

Datadog Report

watson Feb 6, 2025

Choose a reason for hiding this comment

watson Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

watson Feb 6, 2025

Choose a reason for hiding this comment

pr-commenter bot commented Feb 6, 2025 • edited Loading

Benchmarks

scenario:plugin-graphql-with-depth-on-max-18

IlyasShabi left a comment

Choose a reason for hiding this comment

simon-id Feb 6, 2025

Choose a reason for hiding this comment

watson commented Feb 6, 2025 •

edited

Loading

watson commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

codecov bot commented Feb 6, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 6, 2025 •

edited

Loading

watson Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading