chore: ignore *.prof files #4153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
BenchmarksBenchmark execution time: 2025-11-20 13:44:51 Comparing candidate commit d0b2ea6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 0 unstable metrics. |
…ation Replace regex-based symbol parsing with string operations to eliminate per-frame allocations in stack capture. Performance improvements: - parseSymbol: 0 allocs/op (was ~2 allocs/op) - BenchmarkCaptureWithRedaction/depth_10: 38→6 allocs/op (84% reduction) - BenchmarkCaptureWithRedaction/depth_50: 118→6 allocs/op (95% reduction) - Speed: 19.2µs→4.1µs @ depth=10 (79% faster) - Memory: 8966B→5296B @ depth=10 (41% reduction) Allocations are now constant regardless of stack depth.
The segmentPrefixTrie follows a write-once-read-many pattern where all writes occur during package initialization before any concurrent access. After initialization, the trie is effectively immutable and can be safely read by multiple goroutines without synchronization overhead.
Deleted character-based prefixTrie implementation (~130 lines) as segmentPrefixTrie is the only trie used in production code. segmentPrefixTrie provides better performance for path-based prefix matching and is the sole implementation used by the stacktrace filtering system.
Introduced captureStack() as the single source of truth for stack capture implementation, eliminating code duplication across capture functions. This consolidates the iterator(skip, maxDepth, opts).capture() pattern into a single helper, reducing duplicate code by ~20 lines.
Add *.prof to .gitignore to exclude profiling output files.
kakkoyun
changed the base branch from
kakkoyun/11-20-stacktrace-add_capturestack_helper_for_dry_capture_logic
to
graphite-base/4153
kakkoyun
changed the base branch from
graphite-base/4153
to
kakkoyun/11-20-stacktrace-add_capturestack_helper_for_dry_capture_logic
kakkoyun
changed the base branch from
kakkoyun/11-20-stacktrace-add_capturestack_helper_for_dry_capture_logic
to
graphite-base/4153
kakkoyun
force-pushed
the
kakkoyun/11-20-stacktrace-keep_skipandcapturewithinternalframes_name_visible_in
branch
from
216c654 to
d0b2ea6
Compare
kakkoyun
force-pushed
the
graphite-base/4153
branch
from
e38586d to
f3a0f84
Compare
kakkoyun
changed the base branch from
graphite-base/4153
to
kakkoyun/11-20-stacktrace-remove_unused_prefixtrie_implementation
kakkoyun
force-pushed
the
kakkoyun/11-20-stacktrace-remove_unused_prefixtrie_implementation
branch
from
f3a0f84 to
173e13b
Compare
7 tasks
kakkoyun
changed the base branch from
kakkoyun/11-20-stacktrace-remove_unused_prefixtrie_implementation
to
kakkoyun/11-20-stacktrace-remove_unnecessary_locking_from_segmentprefixtrie
kakkoyun
deleted the
kakkoyun/11-20-stacktrace-keep_skipandcapturewithinternalframes_name_visible_in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!