Skip to content

Conversation

@kakkoyun
Copy link
Member

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Copy link
Member Author

kakkoyun commented Nov 20, 2025

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2025

Benchmarks

Benchmark execution time: 2025-11-20 13:54:41

Comparing candidate commit bf07665 in PR branch kakkoyun/11-20-stacktrace-optimize_parsesymbol_with_zero_allocation_implementation with baseline commit 89e0450 in branch graphite-base/4149.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

@kakkoyun kakkoyun force-pushed the kakkoyun/11-20-docs-document_testunit_make_target branch from e673b82 to 19fa72c Compare November 20, 2025 13:00
@kakkoyun kakkoyun force-pushed the kakkoyun/11-20-stacktrace-optimize_parsesymbol_with_zero_allocation_implementation branch from 790d7a8 to ed45a45 Compare November 20, 2025 13:00
@kakkoyun kakkoyun changed the base branch from kakkoyun/11-20-docs-document_testunit_make_target to graphite-base/4149 November 20, 2025 13:00
@kakkoyun kakkoyun changed the base branch from graphite-base/4149 to kakkoyun/11-20-docs-document_testunit_make_target November 20, 2025 13:17
@kakkoyun kakkoyun force-pushed the kakkoyun/11-20-docs-document_testunit_make_target branch 2 times, most recently from fe173f5 to 89e0450 Compare November 20, 2025 13:39
The segmentPrefixTrie follows a write-once-read-many pattern where all
writes occur during package initialization before any concurrent access.

After initialization, the trie is effectively immutable and can be safely
read by multiple goroutines without synchronization overhead.
@kakkoyun kakkoyun force-pushed the kakkoyun/11-20-stacktrace-optimize_parsesymbol_with_zero_allocation_implementation branch from ed45a45 to bf07665 Compare November 20, 2025 13:40
@kakkoyun kakkoyun changed the base branch from kakkoyun/11-20-docs-document_testunit_make_target to graphite-base/4149 November 20, 2025 13:50
@kakkoyun kakkoyun marked this pull request as ready for review November 20, 2025 13:55
@kakkoyun kakkoyun requested a review from a team as a code owner November 20, 2025 13:55
@kakkoyun kakkoyun deleted the branch graphite-base/4149 November 20, 2025 13:56
@kakkoyun kakkoyun closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants