-
Notifications
You must be signed in to change notification settings - Fork 52
FFL-1460 Update Flags SDK to evaluate feature flags synchronously #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yugisu-flux
merged 30 commits into
feature/flags
from
dima/FFL-1460-sync-flag-evaluation-in-rn-sdk
Jan 14, 2026
Merged
FFL-1460 Update Flags SDK to evaluate feature flags synchronously #1064
yugisu-flux
merged 30 commits into
feature/flags
from
dima/FFL-1460-sync-flag-evaluation-in-rn-sdk
Jan 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 2cc11d6 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Merged
4 tasks
…ct-native-ios-wrapper' into dima/FFL-1256-implement-flags-react-native-android-wrapper
Base automatically changed from
dima/FFL-906-implement-flags-react-native-ios-wrapper
to
feature/flags
December 9, 2025 17:16
…per' into dima/FFL-1460-sync-flag-evaluation-in-rn-sdk
…xy` class directly
…nc-flag-evaluation-in-rn-sdk
…nc-flag-evaluation-in-rn-sdk
4 tasks
63bb97a to
e147449
Compare
4 tasks
sbarrio
reviewed
Jan 9, 2026
Base automatically changed from
dima/update-flags-with-latest-v3
to
feature/flags
January 12, 2026 13:29
sbarrio
reviewed
Jan 14, 2026
sbarrio
reviewed
Jan 14, 2026
sbarrio
reviewed
Jan 14, 2026
sbarrio
reviewed
Jan 14, 2026
sbarrio
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the Flags SDK to evaluate feature flags synchronously.
After these changes, the Flags package API surface should look like the following:
DatadogFlagsenable()- Initializes the general Flags SDKgetClient()- Retrieves a client by (an optional) name. The recommended way to get client instances. Clients are actually initialized bysetEvaluationContext.FlagsClient
setEvaluationContext()- Sets evaluation context and fetches flag values from the native SDKs. Should be called before flag evaluations, similarly to the mobile SDKs and the web SDKgetDetails()typed methodsgetValue()typed methodsImplementation details
The FlagsClient architecture has been changed from being a thin bridge/wrapper for native
getDetailscalls to a layer that fetches ALL flags from the native SDK and stores it on the JS side. Individual flag values are synchronously served from this internal cached state via e.g.getBooleanValuemethod. Flag evaluations are tracked internally by calling an exposed nativenativeFlags.trackEvaluationmethod.This way, the native SDKs serve a purpose of fetching and persisting flag configurations, and the JavaScript layer tries to stay as thin as possible, while doing the necessary work for sync evals.
The disadvantages to this approach are: implementing some new features like flags polling or local evaluations would be extra work, due to the duplication of cache between native and RN; iOS and Android SDK repositories are modified to accommodate for these changes.
The other approaches that were evaluated during the implementation
Bump minimum RN version for the Flags SDK specifically, and make
get*Detailscalls synchronous by leveraging JSI.Drop the dependency on native Flags SDKs, use the JavaScript core from https://github.com/DataDog/openfeature-js-client.
Motivation
Flag evaluations should be synchronous. More details here: https://datadoghq.atlassian.net/browse/FFL-1460
The changes in this PR have been developed jointly with:
Review checklist (to be filled by reviewers)