Skip to content

rest: apply sane default timeout on requests #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wdauchy
Copy link

@wdauchy wdauchy commented Jun 5, 2025

datadog API has a default timeout of 60s

We observe regular error from lambda client using this lib where the connection is open without any timeout leading to write errors and connection interrupted by our servers.

this patch aims to set a sane default for requests.

@wdauchy wdauchy force-pushed the william.dauchy/0 branch from 06da367 to 8d9a39d Compare June 5, 2025 08:40
@wdauchy wdauchy marked this pull request as ready for review June 5, 2025 08:53
@wdauchy wdauchy requested review from a team as code owners June 5, 2025 08:53
@wdauchy wdauchy force-pushed the william.dauchy/0 branch from 8d9a39d to 6664336 Compare June 5, 2025 08:57
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 7 times, most recently from 4c7eec4 to d4f6d42 Compare June 5, 2025 12:39
datadog API has a default timeout of 60s

We observe regular error from lambda client using this lib where the
connection is open without any timeout leading to write errors and
connection interrupted by our servers.

this patch aims to set a sane default for requests.

Signed-off-by: William Dauchy <[email protected]>
@wdauchy wdauchy force-pushed the william.dauchy/0 branch from d4f6d42 to 0609e32 Compare June 5, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant