rest: apply sane default timeout on requests

datadog API has a default timeout of 60s

We observe regular error from lambda client using this lib where the
connection is open without any timeout leading to write errors and
connection interrupted by our servers.

this patch aims to set a sane default for requests.

we also bump aiosonic version to benefit from better connection
handling in 0.24.0:
https://github.com/sonic182/aiosonic/blob/54f8b9f3e13bac87071826d942da7496ecc2a690/CHANGELOG.md?plain=1#L9
```
- Multiple pools configurations in client connector per target host.
  - conn idle timeout closing for more robust conns.
```

Signed-off-by: William Dauchy <[email protected]>

Author: wdauchy

setup.cfg

@@ -51,11 +51,11 @@ setup_requires =
 apm =
     ddtrace>=1.15.0
 async =
-    aiosonic==0.15.1
+    aiosonic==0.24.0
 zstandard =
     zstandard
 tests =
-    aiosonic==0.15.1
+    aiosonic==0.24.0
     glom
     jinja2
     pytest<8.0.0

src/datadog_api_client/rest.py

@@ -25,6 +25,8 @@
 
 RETRY_AFTER_STATUS_CODES = frozenset([429, 500, 501, 502, 503, 504, 505, 506, 507, 509, 510, 511, 512])
 RETRY_ALLOWED_METHODS = frozenset(["GET", "PUT", "DELETE", "POST", "PATCH"])
+# apply sane default for calls to datadog API which has 60s timeout
+DEFAULT_TIMEOUT = 55
 
 
 class ClientRetry(urllib3.util.Retry):
@@ -140,7 +142,7 @@ def request(
         post_params = post_params or {}
         headers = headers or {}
 
-        timeout = None
+        timeout = urllib3.Timeout(total=DEFAULT_TIMEOUT)
         if request_timeout:
             if isinstance(request_timeout, (int, float)):
                 timeout = urllib3.Timeout(total=request_timeout)
@@ -290,13 +292,14 @@ async def request(
                                 (connection, read) timeouts.
         """
         assert not post_params, "not supported for now"
+        timeout = Timeouts(request_timeout=DEFAULT_TIMEOUT)
         if request_timeout is not None:
             from aiosonic.timeout import Timeouts  # type: ignore
 
             if isinstance(request_timeout, (int, float)):
-                request_timeout = Timeouts(request_timeout=request_timeout)
+                timeout = Timeouts(request_timeout=request_timeout)
             else:
-                request_timeout = Timeouts(sock_connect=request_timeout[0], sock_read=request_timeout[1])
+                timeout = Timeouts(sock_connect=request_timeout[0], sock_read=request_timeout[1])
         request_body = None
         if (
             "Content-Type" not in headers
@@ -317,7 +320,7 @@ async def request(
         counter = 0
         while True:
             response = await self._client.request(
-                url, method, headers, query_params, request_body, timeouts=request_timeout
+                url, method, headers, query_params, request_body, timeouts=timeout
             )
             retry = self._retry(method, response, counter)
             if not retry: