[PF-2978] High severity security issue - Upgrade logback-core #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
rtitle
commented
Dec 4, 2023
| @@ -119,8 +118,7 @@ protected static void initializeLogging(ConfigurableApplicationContext applicati | |||
| // seems to work. But if we encounter future issues in human-readable logging control, this | |||
| // is a reasonable place to look more closely. | |||
| logbackLogger.detachAndStopAllAppenders(); | |||
| new ContextInitializer(logbackLogger.getLoggerContext()) | |||
| .configureByResource(ResourceUtils.getURL("classpath:logback.xml")); | |||
| new ContextInitializer(logbackLogger.getLoggerContext()).autoConfig(); | |||
There was a problem hiding this comment.
I think this is the same thing. The old method was deprecrated and now removed, and said:
/**
* This method is deprecated with no replacement
* @param url
* @throws JoranException
*/
@Deprecated
public void configureByResource(URL url) throws JoranException {
aherbst-broad
approved these changes
Dec 4, 2023
dvoet
approved these changes
Dec 4, 2023
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/PF-2978
CVE-2023-6378 is fixed as of logback
1.4.14: https://logback.qos.ch/news.html#1.3.14However spring-boot pulls in logback versions which are vulnerable:
spring-boot:3.1.2pulls inlogback-core:1.4.8spring-boot:3.2.0pulls inlogback-core:1.4.11See also this spring-boot issue from today: spring-projects/spring-boot#38643
So I'm leaving spring-boot alone, and explicitly pulling in logback from TCL, which seems to work.
Downstream services will need to update their TCL dependency.