[PF-2979] Upgrade Janitor to Spring Boot 3 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtitle
changed the title
rtitle
commented
Jan 4, 2024
| implementation group: 'com.google.cloud', name: 'google-cloud-billing', version: '2.3.0' | ||
| implementation group: 'com.google.cloud', name: 'google-cloud-core-http', version: '2.8.0' | ||
| implementation group: 'com.google.cloud', name: 'google-cloud-pubsub', version: '1.120.0' | ||
| implementation group: 'com.google.cloud', name: 'google-cloud-storage', version: '2.9.2' |
There was a problem hiding this comment.
Removed some Google dependencies that get included through CRL.
rtitle
commented
Jan 4, 2024
| private MetricsHelper() {} | ||
|
|
||
| @Component | ||
| public class MetricsHelper { |
There was a problem hiding this comment.
Refactored MetricsHelper to use OpenTelemetry API. Really used RBS as a model.
okotsopoulos
approved these changes
Jan 4, 2024
| @@ -131,27 +149,6 @@ dependencies { | |||
| implementation('org.bouncycastle:bcpkix-jdk15on:1.70') | |||
| implementation('org.bouncycastle:bcprov-jdk15on:1.70') | |||
| spotbugs('org.apache.bcel:bcel:6.6.1') | |||
| // TODO(PF-2299): Remove these once all dependencies are using >3.0.0. This | |||
src/test/java/bio/terra/janitor/app/controller/JanitorApiControllerTest.java
Outdated
Show resolved
Hide resolved
zloery
approved these changes
Jan 4, 2024
dvoet
approved these changes
Jan 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/PF-2979
Used DataBiosphere/terra-resource-buffer#285 as a model, which is similar to Janitor.
Upgrades Janitor to Spring Boot 3, along with:
Tested via unit and integration tests. Also ran Janitor locally and manually submitted pubsub messages, and verified resources were deleted.