Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion 2025-01-28 prod (#6858) #6865

Merged
merged 111 commits into from
Feb 1, 2025
Merged

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Jan 29, 2025

Connected issue: #6858

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches promotions/yyyy-mm-dd-prod
  • On ZenHub, PR is connected to the promotion issue it resolves
  • PR description links to connected issue
  • Title of connected issue matches Promotion yyyy-mm-dd
  • PR title starts with title of connected issue followed by prod
  • PR title references the connected issue

Author (reindex, API changes)

  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod or requires a full reindex or is not labeledreindex:prod

Author (upgrading deployments)

  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Pushed PR branch to GitHub
  • Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply_keep_unused or this PR is not labeled deploy:shared
  • Ran _select prod.gitlab && python scripts/create_gitlab_snapshot.py --no-restart (see operator manual for details) or this PR is not labeled backup:gitlab
  • Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator or this PR is not labeled deploy:gitlab

System administrator

  • Background migrations for prod.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Ran _select prod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Ran _select prod.shared && make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Deleted PR branch from GitHub
  • Moved connected issue to Merged stable column on ZenHub
  • Moved promoted issues from Merged lower to Merged stable column on ZenHub
  • Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or this PR does not require reindexing prod
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or this PR does not require reindexing prod
  • Emptied fail queues in prod or this PR does not require reindexing prod
  • Restarted the Data Browser pipeline for the ucsc/hca/prod branch on GitLab in prod or this PR does not require reindexing prod
  • Restarted the Data Browser pipeline for the ucsc/lungmap/prod branch on GitLab in prod or this PR does not require reindexing prod
  • Restarted deploy_browser job in the GitLab pipeline for this PR in prod or this PR does not require reindexing prod

Operator

  • PR is assigned to only the system administrator

System administrator

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

achave11-ucsc and others added 30 commits November 7, 2024 21:50
@github-actions github-actions bot added the orange [process] Done by the Azul team label Jan 29, 2025
@dsotirho-ucsc dsotirho-ucsc added API API change affecting callers deploy:shared [process] PR requires deploying `shared` component deploy:gitlab [process] PR requires deploying `gitlab` component deploy:runner [process] PR requires deploying `runner` component backup:gitlab [process] PR requires backing up GitLab instances labels Jan 29, 2025
@coveralls
Copy link

Coverage Status

coverage: 85.564% (-0.1%) from 85.686%
when pulling 504fd8c on promotions/2025-01-28-prod
into 1dd9b25 on prod.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Jan 30, 2025
@dsotirho-ucsc dsotirho-ucsc merged commit d369f55 into prod Feb 1, 2025
111 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the promotions/2025-01-28-prod branch February 1, 2025 04:47
@hannes-ucsc hannes-ucsc removed their assignment Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API change affecting callers backup:gitlab [process] PR requires backing up GitLab instances deploy:gitlab [process] PR requires deploying `gitlab` component deploy:runner [process] PR requires deploying `runner` component deploy:shared [process] PR requires deploying `shared` component no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants