Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Localization strings for Trophy advancements #301

Merged
merged 17 commits into from
Jan 14, 2025

Conversation

ToastedWookiee
Copy link
Contributor

Updates Localization strings for Trophy advancements
also changes title of Magenta Trophy from Megenta to Magenta, localization string changed from magenta_trophy to megenta_trophy

@Darkosto Darkosto merged commit ea891e0 into DarkPacks:develop Jan 14, 2025
1 check passed
@nageih nageih mentioned this pull request Jan 14, 2025
6 tasks
@nageih
Copy link

nageih commented Jan 14, 2025

Hello! I'm glad to see that there are still people contributing to localization. But these changes don't seem to make much sense, and I think changing the name of the criterion would be more aesthetical and reasonable than changing the name of the translation key, as I did in this PR #238. With the merge of this PR, the conflict of my PR becomes more serious, and I am not sure how to solve it better

@ToastedWookiee
Copy link
Contributor Author

ToastedWookiee commented Jan 14, 2025

It had to be done this way, if we change the criterion in the advancements, it would make them "new" advancements and reset them for players. So the only way to update the trophy advancements to use localization was to change the strings they were referencing to the existing advancement criterion.

Darkosto didn't want to reset advancement progress for existing players.

All this did was update the lang file to reference to the existing criterion names for those advancements, so if you change them in other languages they will be properly replaced, without needing to reset the advancements.

We don't want to make any changes to things that will reset things like advancements for people, so you may need to adjust your PR to account for the existing criterion for advancements. Darkosto may know more what needs to be examined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants