-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n modpack and CHS local #238
Open
nageih
wants to merge
20
commits into
DarkPacks:develop
Choose a base branch
from
VM-Chinese-translate-group:chs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHS Chs (#1) * inital commit * 校对 根据意见补充 1 任务书review完成 Update zh_cn.json 第二次 update need review * 应用校对意见 * 补充key * done * Update tooltips.zs * Update root.json 坩埚->木坩埚
initial commit
nageih
commented
Jan 10, 2025
src/minecraft/config/mysticalcustomization/crops/black_crop.json
Outdated
Show resolved
Hide resolved
sorry for these ugly commit, I can't sqaush them😰. |
Dutchs
reviewed
Jan 10, 2025
...uired_data/skyfactory_5/data/craftingforblockheads/craftingforblockheads/crafting_stick.json
Outdated
Show resolved
Hide resolved
mystical agriculture crops
Dutchs
reviewed
Jan 11, 2025
协作 Co-authored-by: 3093FengMing <[email protected]> Co-Authored-By: youyihj <[email protected]> Co-Authored-By: 3093FengMing <[email protected]> Co-Authored-By: youyihj <[email protected]> Co-Authored-By: 3093FengMing <[email protected]>
Just now, Pr #301 is merged, the changes in it are the same as in this PR, so the advancements part in this PR all conflicts with the repo, I don't quite understand how to solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resovled #55 #97
All the parts of the PR
Task Book
Thanks to textrue's mod, it's able to be i18n. The text has already been replaced with translation key. And it's works successfully according to my test. The python program is used to handle the texts and translation keys.
Mytiscal Customization
The texts that need to be i18n are the name of custom crops. According to the doc, I deleted the
name
key and put the translation keys into lang file. Also it works successfully according to my test.Crafting for Blockheads Recipes
The names of recipes also don't have translation keys. After reading the doc of the mod, I find the name it able to be translation keys. So I replaced them with translation keys.
Other datapack things
It includes A lot of advancements, mcfunctions and jei infos. About advancements, it's not worth going into detail. I just replace the text with translation keys, it's in vanilla. About mcfunctions, I just revised a text component so it's ok. The jei info is the same as mcfuntions because actually it's some text components as well. Also all the things works successfully.
Translations of mods
I add some Chinese lang file into the PR, and it includes some mods in the modpack. It's simple so I'm sure it's ok.
Crafttweakers scripts
Tbh, the changes need testing, because I'm poor at crafttweaker. So I don't know whether the changes will work successfully or not. All I know for sure is, the
tooltip.zs
andmobs.zs
work successfully. And thevillager_trade.zs
is ok as well. I read source codes of the lootbag mod, and I find theName
it can be translation keys. It's related codes.