Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n modpack and CHS local #238

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

nageih
Copy link

@nageih nageih commented Jan 10, 2025

resovled #55 #97

All the parts of the PR

  • Task Book
  • Mytiscal Customization
  • Crafting for Blockheads Recipes
  • Other datapack things
  • Some translations of mods
  • Crafttweaker scripts

Task Book

Thanks to textrue's mod, it's able to be i18n. The text has already been replaced with translation key. And it's works successfully according to my test. The python program is used to handle the texts and translation keys.

Mytiscal Customization

The texts that need to be i18n are the name of custom crops. According to the doc, I deleted the name key and put the translation keys into lang file. Also it works successfully according to my test.

Crafting for Blockheads Recipes

The names of recipes also don't have translation keys. After reading the doc of the mod, I find the name it able to be translation keys. So I replaced them with translation keys.

Other datapack things

It includes A lot of advancements, mcfunctions and jei infos. About advancements, it's not worth going into detail. I just replace the text with translation keys, it's in vanilla. About mcfunctions, I just revised a text component so it's ok. The jei info is the same as mcfuntions because actually it's some text components as well. Also all the things works successfully.

Translations of mods

I add some Chinese lang file into the PR, and it includes some mods in the modpack. It's simple so I'm sure it's ok.

Crafttweakers scripts

Tbh, the changes need testing, because I'm poor at crafttweaker. So I don't know whether the changes will work successfully or not. All I know for sure is, the tooltip.zs and mobs.zs work successfully. And the villager_trade.zs is ok as well. I read source codes of the lootbag mod, and I find the Name it can be translation keys. It's related codes.

    public Component getName(ItemStack stack) {
        return Component.translatable(stack.getOrCreateTag().getString("Name")).withStyle(Style.EMPTY.withColor(stack.getOrCreateTag().getInt("Color")));
    }

nageih and others added 12 commits January 2, 2025 19:17
根据意见补充

1

任务书review完成

Update zh_cn.json

第二次

update need review
CHS

Chs (#1)

* inital commit

* 校对

根据意见补充

1

任务书review完成

Update zh_cn.json

第二次

update need review

* 应用校对意见

* 补充key

* done

* Update tooltips.zs

* Update root.json

坩埚->木坩埚
@nageih nageih marked this pull request as draft January 10, 2025 16:34
@nageih
Copy link
Author

nageih commented Jan 10, 2025

sorry for these ugly commit, I can't sqaush them😰.

@Darkosto Darkosto added the Blocked Cannot be completed without outside help or fixes label Jan 12, 2025
nageih and others added 3 commits January 12, 2025 13:37
协作

Co-authored-by: 3093FengMing
 <[email protected]>

Co-Authored-By: youyihj <[email protected]> Co-Authored-By: 3093FengMing <[email protected]>
Co-Authored-By: youyihj <[email protected]>
Co-Authored-By: 3093FengMing <[email protected]>
@nageih
Copy link
Author

nageih commented Jan 12, 2025

@Dutchs @Darkosto The PR is ready to merge. Expect to merge to in case that it will conflicts with other PRs.
I don't know how to add mod to this modpack, it should be added the mod, which allow the task book to be i18n.

@nageih nageih marked this pull request as ready for review January 12, 2025 15:56
@nageih
Copy link
Author

nageih commented Jan 14, 2025

Just now, Pr #301 is merged, the changes in it are the same as in this PR, so the advancements part in this PR all conflicts with the repo, I don't quite understand how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Cannot be completed without outside help or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants