Skip to content

Update LcmDrivenLoop to add a message queue size parameter #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Brian-Acosta
Copy link
Contributor

@Brian-Acosta Brian-Acosta commented Oct 3, 2024

Addresses RobotLocomotion/drake#15234 by adding the ability to set the queue size of LcmDrivenLoop's internal subscribers, and handling the lcm subscription until the queue is empty (up to date) on each loop.


This change is Reviewable

Copy link
Contributor

@mposa mposa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bit of documentation, and just have one additional comment/question.

Remove unused wait_for_message
Copy link
Contributor

@mposa mposa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sharanyashastry)

sharanyashastry added a commit that referenced this pull request Oct 7, 2024
… stored the first message it received after being cleared and never replaced them with newer messages. This fix makes the buffer size bigger and ensures that the latest message is picked up before clearing the buffer. RobotLocomotion/drake#15234 details this issue and the PR on main #366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants