WESTMIDLANDS| ITP-MAY 2025| ROJA ALAGURAJAN| Module Structuring and Testing Data|Sprint-3 #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
cjyuan
reviewed
Jul 19, 2025
Comment on lines
+3
to
+18
| /*test("should identify right angle (90°)", () => { | ||
| expect(getAngleType(90)).toEqual("Right angle");}); | ||
|
|
||
| test("should identify acute angle (45°)", () => { | ||
| expect(getAngleType(45)).toEqual("Acute angle");}); | ||
|
|
||
| test("should identify obtuse angle (120°)", () => { | ||
| expect(getAngleType(120)).toEqual("Obtuse angle");}); | ||
|
|
||
| test("should identify straight angle (180°)", () => { | ||
| expect(getAngleType(180)).toEqual("Straight angle");}); | ||
|
|
||
| test("should identify reflex angle (220°)", () => { | ||
| expect(getAngleType(220)).toEqual("Reflex angle");}); | ||
|
|
||
| */ |
There was a problem hiding this comment.
Any reason to keep this code? Code submitted to a PR is like the final work. As such, it is best practices to keep the code in the PR as clean as possible, including removal of unused code.
Comment on lines
+10
to
+13
| test("should return rank for Number Cards", () => { | ||
| const fiveofHearts = getCardValue("5♥"); | ||
| expect(fiveofHearts).toEqual(5); | ||
| }); |
There was a problem hiding this comment.
"2♥" and "10♥" -- the boundary values usually worth testing.
Given that the set of possible values is small (only 9 different values), we can even use a loop to generate all possible test values.
The same principle applies to the test that deals with the face cards.
Comment on lines
+20
to
+23
| test("should return 11 for AceCard", () => { | ||
| const AceCard = getCardValue("A♥"); | ||
| expect(AceCard).toEqual(11); | ||
| }); |
There was a problem hiding this comment.
This test is similar to the test at lines 3-7. (This comment was from the previous review).
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.