WESTMIDLANDS| ITP-MAY 2025| ROJA ALAGURAJAN| Module Structuring and Testing Data|Sprint-3 #645
Conversation
|
Hi @cjyuan , |
cjyuan
added
Review in progress
There was a problem hiding this comment.
Deleted files are still considered modified files. One way to revert changes made to the files in Sprint-1 and Sprint-2 folders is to copy the version of the files from your main branch.
- You can download your
mainbranch from GitHub as a ZIP file, then copy Sprint-1 and Sprint-2 folders from the ZIP to your repo while you are on thesprint3_modulebranch in VSCode.
Can you restore the files in Sprint-1 and Sprint-2 folders in this branch by the version of the corresponding files in main?
Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Outdated
Show resolved
Hide resolved
cjyuan
added
Reviewed
| test("should return 11 for AceCard", () => { | ||
| const AceCard = getCardValue("A♥"); | ||
| expect(AceCard).toEqual(11); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This test is similar to the test at lines 3-7.
| const facecards = getCardValue("Q♥"); | ||
| expect(facecards).toEqual(10); |
There was a problem hiding this comment.
Could also test J and K to make the test more comprehensive.
| test("should return rank for Number Cards", () => { | ||
| const fiveofHearts = getCardValue("5♥"); | ||
| expect(fiveofHearts).toEqual(5); | ||
| }); |
There was a problem hiding this comment.
Could also consider testing more values, especially the boundary cases like 2 and 10.
Hi @cjyuan, |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.