Skip to content

Sprint 3 implement task reword #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Poonam-raj wants to merge 8 commits into
base: main
Choose a base branch
from
+5 −3
Open

Sprint 3 implement task reword #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5fe338c
Adding dead code backlog task
Poonam-raj Jan 9, 2026
9987ade
reordering backlog tasks for sprint 3 due to added dead code work
Poonam-raj Jan 9, 2026
9a4527a
make dead code required in readme
Poonam-raj Jan 13, 2026
f0232fe
Merge branch 'main' of https://github.com/CodeYourFuture/Module-Struc…
Poonam-raj Mar 23, 2026
27c88ca
reword to not push for tdd yet
Poonam-raj Mar 23, 2026
1b3febe
making error handling clearer
Poonam-raj Mar 23, 2026
6ab29ab
making error handling clearer
Poonam-raj Mar 23, 2026
da7d62c
console err instead of log
Poonam-raj Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-3/1-implement-and-rewrite-tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ to choose test values that thoroughly test a function.
In the `implement` directory you've got a number of functions you'll need to implement.
For each function, you also have a number of different cases you'll need to check for your function.

Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step.
Write your implementation and then write your tests to cover the cases the function should fulfil.
Copy link
Member

@illicitonion illicitonion Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not actively enforce an order?

Suggested change
Write your implementation and then write your tests to cover the cases the function should fulfil.
Write your implementation and your tests to cover the cases the function should fulfil.


Here is a recommended order:

Expand Down
6 changes: 4 additions & 2 deletions Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ try {
getCardValue("invalid");

// This line will not be reached if an error is thrown as expected
console.error("Error was not thrown for invalid card");
} catch (e) {}
console.error("Error was not thrown for invalid card 😢");
} catch (e) {
console.error("Error thrown for invalid card 🎉");
Copy link
Member

@illicitonion illicitonion Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.error("Error thrown for invalid card 🎉");
console.log("Error thrown for invalid card 🎉");

}

// What other invalid card cases can you think of?
Loading