Open
Conversation
| } catch (e) {} | ||
| console.error("Error was not thrown for invalid card 😢"); | ||
| } catch (e) { | ||
| console.error("Error thrown for invalid card 🎉"); |
Member
There was a problem hiding this comment.
Suggested change
| console.error("Error thrown for invalid card 🎉"); | |
| console.log("Error thrown for invalid card 🎉"); |
| For each function, you also have a number of different cases you'll need to check for your function. | ||
|
|
||
| Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step. | ||
| Write your implementation and then write your tests to cover the cases the function should fulfil. |
Member
There was a problem hiding this comment.
Let's not actively enforce an order?
Suggested change
| Write your implementation and then write your tests to cover the cases the function should fulfil. | |
| Write your implementation and your tests to cover the cases the function should fulfil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
console.errorto the catch to make use of catch, indicate successful error handling