generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 149
Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-3|Alarm Clock #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sheida-shab
wants to merge
15
commits into
CodeYourFuture:main
Choose a base branch
from
sheida-shab:Sprint3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,725
−3
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
abdcbfd
Rename Title,Get elements , Try to get the input
sheida-shab 3e2debe
updating the time remaining content
sheida-shab 32f9d24
implement function updateDisplayTime
sheida-shab 55f13a4
add and testing interval
sheida-shab a674f0b
using interval function to count down the seconds
sheida-shab e2eb3bb
change the background color of page and the stop button
sheida-shab 244219b
some little changes
sheida-shab 8d01d83
flash page color using set interval and global var
sheida-shab 35c72e7
checked all test cases and passed
sheida-shab 5879ef2
delete repeated functions and fix the bug of click set button multip…
sheida-shab f589b5e
replace var with let
sheida-shab 380fa7e
declare variables min and sec as const
sheida-shab dcd9cfc
fix global variable declaration
sheida-shab a3cf780
fix indentation
sheida-shab d718785
Revert the quotes.js changes
sheida-shab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they both hold interval ID, can you keep the naming convention consistent?
Note: When I first saw the name
flashColor
, I cannot figure out the purpose of the variable.