Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-3|Alarm Clock #631

sheida-shab · 2025-07-16T22:50:12Z

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

I have done all requirements for setting an alarm clock step by step and passed all the tests.

cjyuan

Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Can you fix the issue?
Some of the function definitions appear twice. Can you remove the unwanted copies?
We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file? (You don't have to undo the changes you made this time, I just want to raise your awareness)

cjyuan · 2025-07-17T22:54:48Z

Sprint-3/alarmclock/alarmclock.js

@@ -1,5 +1,98 @@
-function setAlarm() {}
+var flashColor; 


Why use var instead of let?

I used var out of old habit because I used to work with it before, and I wasn’t really paying attention to why I was using it.

cjyuan · 2025-07-17T22:55:53Z

Sprint-3/alarmclock/alarmclock.js

+  if (inputTime <= 0 || isNaN(inputTime)) {
+    alert("invalid input!!!");
+    return;
+  }


Some unusual input values that can make your app behave abnormally can still pass this check. Can you add code to sanitise them?

I have already handled empty input, negative numbers, decimals, and zero values. Since the input field is defined as type 'number', non-numeric inputs are also prevented altogether. The only thing left, in my opinion, is controlling very large numbers. Do you think it's necessary to set a limit on the numeric value that can be entered? Also, I don’t have any other ideas about unusual inputs that might cause issues—if possible, could you please guide me on that?"

cjyuan · 2025-07-17T22:59:20Z

Sprint-3/alarmclock/alarmclock.js

+  let min = String(Math.floor(inputTime / 60)).padStart(2, "0");
+  let sec = String(inputTime % 60).padStart(2, "0");


Can consider declaring these two variables with const because they won't be reassigned any value.

Sure,you are right.I fixed it.

cjyuan · 2025-07-17T23:04:32Z

Sprint-3/alarmclock/alarmclock.js

+  document.getElementById("stop").style.backgroundColor = "rgb(191, 115, 47)";
+  document.body.style.backgroundColor = "rgb(218, 178, 119)";
+   let flashColor=setInterval(() => {
+    if(document.body.style.backgroundColor === "rgb(218, 178, 119)"){
+      document.body.style.backgroundColor = "white";
+    }else{
+      document.body.style.backgroundColor = "rgb(218, 178, 119)";


Could consider preparing several CSS classes in a CSS file and then assign/remove CSS class to these element to change their appearance. This way, if we want to change the styles (including color), we don't have to modify the JS code.

Thank you for your guidance, I understand, but due to lack of time, I’m unable to make this change right now. If you don’t mind, and there’s no problem with it, I’d like to leave it as is for now.

…e time

sheida-shab · 2025-07-18T21:08:11Z

I fixed the issues you mentioned. Now, even if the user clicks the “Set Alarm” button multiple times, the timer works properly . I also removed the duplicate functions .

I asked ChatGPT about the DO NOT EDIT BELOW HERE part and now I get why we shouldn’t touch that section.

Thanks for your guidance—it really helped me improve the code and learn new things.

cjyuan · 2025-07-19T00:26:45Z

Sprint-3/alarmclock/alarmclock.js

@@ -1,85 +1,26 @@
-var flashColor; 
+let flashColor, secondsInterval, inputTime; 


The inputTime in function setAlarm() is not related to the inputTime parameter in updateDisplayTime(). In both functions, the variable/parameter is used locally, so inputTime should not be declared at in the top-level scope.

Also, since inputTime in only assigned once in function setAlarm(), it could better be declared using const inside that function.

I fixed the issue.

cjyuan · 2025-07-19T00:29:25Z

Sprint-3/alarmclock/alarmclock.js

+  let remainingTime = inputTime;
+  updateDisplayTime(remainingTime);
+
+    secondsInterval=setInterval(() => {
+      remainingTime--;
+    updateDisplayTime(remainingTime);
+    if (remainingTime === 0) {
      clearInterval(secondsInterval);
-           
+      playAlarm();
    } 
  }, 1000);


Indentation is a bit off.

I fixed it.

cjyuan · 2025-07-19T00:30:25Z

Sprint-3/quote-generator/quotes.js

This file should not be included in the alarm-clock PR. Can you revert the change made to this file?

I reverted the changes.

sheida-shab added 9 commits July 16, 2025 21:14

Rename Title,Get elements , Try to get the input

abdcbfd

updating the time remaining content

3e2debe

implement function updateDisplayTime

32f9d24

add and testing interval

55f13a4

using interval function to count down the seconds

a674f0b

change the background color of page and the stop button

e2eb3bb

some little changes

244219b

flash page color using set interval and global var

8d01d83

checked all test cases and passed

35c72e7

sheida-shab added the Needs Review Participant to add when requesting review label Jul 16, 2025

cjyuan reviewed Jul 17, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 17, 2025

delete repeated functions and fix the bug of click set button multipl…

5879ef2

…e time

sheida-shab added Needs Review Participant to add when requesting review and removed Needs Review Participant to add when requesting review labels Jul 18, 2025

sheida-shab added 2 commits July 18, 2025 22:15

replace var with let

f589b5e

declare variables min and sec as const

380fa7e

sheida-shab added the Needs Review Participant to add when requesting review label Jul 18, 2025

cjyuan reviewed Jul 19, 2025

View reviewed changes

cjyuan removed the Needs Review Participant to add when requesting review label Jul 19, 2025

sheida-shab added 3 commits July 20, 2025 20:30

fix global variable declaration

dcd9cfc

fix indentation

a3cf780

Revert the quotes.js changes

d718785

sheida-shab added the Needs Review Participant to add when requesting review label Jul 20, 2025

		let min = String(Math.floor(inputTime / 60)).padStart(2, "0");
		let sec = String(inputTime % 60).padStart(2, "0");

		@@ -1,85 +1,26 @@
		var flashColor;
		let flashColor, secondsInterval, inputTime;

Uh oh!

Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-3|Alarm Clock #631

Are you sure you want to change the base?

Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-3|Alarm Clock #631

Conversation

sheida-shab commented Jul 16, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheida-shab Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheida-shab commented Jul 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sheida-shab Jul 18, 2025 •

edited

Loading