generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 153
Glasgow | ITP May 25 | Mirabelle Morah | Data Groups | Sprint-3 | Alarm Clock #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mirabellemorah
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
mirabellemorah:sprint-3/alarmclock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d78cae3
Adjust CSS
mirabellemorah c7499b9
Alarm clock done
mirabellemorah ebcd742
adjusted css in alarm clock
mirabellemorah 0ef49cd
Added comments on why ignoring some comments
mirabellemorah 0591bbb
2 changes - margin (extra) taken off and input reset to empty once "S…
mirabellemorah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,73 @@ | ||
body { | ||
background-color: #f0f0f0; | ||
font-family: "Arial", sans-serif; | ||
padding: 0; | ||
font-family: rubik, sans-serif; | ||
margin: 10px 0; | ||
} | ||
|
||
.centre { | ||
position: fixed; | ||
top: 50%; | ||
left: 50%; | ||
-webkit-transform: translate(-50%, -50%); | ||
transform: translate(-50%, -50%); | ||
display: inline-block; | ||
text-align: center; | ||
} | ||
|
||
h1 { | ||
text-align: center; | ||
font-size: clamp(1rem, 4vw, 5rem); | ||
} | ||
|
||
#setTime { | ||
font-size: clamp(1rem, 2vw, 2rem); | ||
margin: 10px; | ||
display: inline-block; | ||
color: #1b58dbc2; | ||
} | ||
|
||
#alarmSet { | ||
margin: 20px; | ||
margin: 20px 40px; | ||
padding: 20px; | ||
max-width: 400px; | ||
height: 100px; | ||
font-size: clamp(1rem, 2vw, 2rem); | ||
box-shadow: #1b58db66 10px 10px; | ||
border-radius: 3px; | ||
border: 0.3px solid rgba(2, 6, 15, 0.4); | ||
transition: all cubic-bezier(0.165, 0.84, 0.44, 1) 0.9s; | ||
} | ||
|
||
h1 { | ||
text-align: center; | ||
#alarmSet:hover { | ||
box-shadow: #042b7ec4 20px 20px; | ||
transform: translate(-10px, -10px); | ||
} | ||
|
||
#alarmSet:focus { | ||
outline: none; | ||
box-shadow: rgba(29, 30, 37, 0.871) 20px 20px; | ||
transform: translate(-10px, -10px); | ||
} | ||
|
||
button { | ||
background-color: #1b58db66; | ||
border: none; | ||
color: white; | ||
padding: 15px 32px; | ||
display: inline-block; | ||
font-size: clamp(1rem, 2vw, 2rem); | ||
margin-top: 60px; | ||
margin-left: 20px; | ||
margin-right: 20px; | ||
cursor: pointer; | ||
box-shadow: rgba(0, 0, 0, 0.114) 10px 10px; | ||
border-radius: 3px; | ||
transition: all cubic-bezier(0.165, 0.84, 0.44, 1) 0.9s; | ||
} | ||
|
||
button:hover { | ||
box-shadow: #042b7ec4 20px 20px; | ||
transform: translate(-10px, -10px); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also consider resetting the
input
to be empty. This way you can let the user know that an action has indeed happened, but it did not resolve into any meaningful result as the input was not valid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put this into consideration and actioned.