Glasgow | ITP May 25 | Mirabelle Morah | Data Groups | Sprint-3 | Alarm Clock

[mirabellemorah]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

1. I adjusted the CSS to create a new one
2. Updated javascript

Questions

Nil. Thank you.

[YoanHlebarov]

Well done! You have done a good job at finishing the code for the alarm. A couple of small comments that you should resolve easily.

I would consider two ideas that I think would be useful for you. You clearly have a good understanding of the code at this stage, so you can think about user experience and code readability.

User Experience is very important, you want to make sure your customers want and enjoy to use the products you create. Think how you use apps, what kind of feedback is there when you take an action? How do you see errors? What happens when you try to do something that you can't/not allowed to? Think how these are handled by other well designed apps and how you can integrate that in your work.

Code readability is another one of those "nice to do" things. If others are reading your code, you want to make sure it is easily understood and it makes sense. Often times you may find yourself able to achieve something in code with a single line. That sounds great, but you should always consider if it is easy to read for others, or even for yourself a year down the line.

[YoanHlebarov]

I would also consider resetting the input to be empty. This way you can let the user know that an action has indeed happened, but it did not resolve into any meaningful result as the input was not valid.

[mirabellemorah]

I have put this into consideration and actioned.

[YoanHlebarov]

You don't need two margin declarations here. See which one you need. As a side question - which of these two do you think will take precedence here?

[mirabellemorah]

You're right that was an oversight. The last margin will take effect "margin: 10px 0; because it's being read in a 'cascading' format. I have taken off the first one

[mirabellemorah]

Thank you for the feedback! I have taken off the extra margin and made the input box reset to "empty" once "set alarm" button is hit, completed the two comments now. On your feedback on UX and code understanding, I will keep improving on this. Thanks.

Well done! You have done a good job at finishing the code for the alarm. A couple of small comments that you should resolve easily.

I would consider two ideas that I think would be useful for you. You clearly have a good understanding of the code at this stage, so you can think about user experience and code readability.

User Experience is very important, you want to make sure your customers want and enjoy to use the products you create. Think how you use apps, what kind of feedback is there when you take an action? How do you see errors? What happens when you try to do something that you can't/not allowed to? Think how these are handled by other well designed apps and how you can integrate that in your work.

Code readability is another one of those "nice to do" things. If others are reading your code, you want to make sure it is easily understood and it makes sense. Often times you may find yourself able to achieve something in code with a single line. That sounds great, but you should always consider if it is easy to read for others, or even for yourself a year down the line.

[YoanHlebarov]

Thank you for addressing those. Keep up the great work! I think this covers all requirements for the task so I shall mark it as complete.