Code Tidyup #13
Closed
Code Tidyup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookie is now being set by Javascript, if server side version is wanted it should needs to be rewritten to use the help class.
…ose as a culture that is not found will use the default anyway, so it is a needless scan of a large array.
…h instead of processing the whole array.
|
Oh, this PR also addresses my issue #11 Should have tried to make this PR against that issue sorry. |
|
Done |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a bunch of commits fixing issues I saw in the codebase when installing it into one of my projects.
I have split up into plenty of commits, so we can pull it apart if not all are wanted.
I have removed a lot of code and CSS that was simply not being used, and looked like it was from an earlier implementation.
I also made some changes to the CultureHelper to remove some code I didn't think was needed and add a few comments to help people understand what it is doing.