Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS/JS/Partial #11

Closed
csainty opened this issue Mar 19, 2012 · 2 comments
Closed

CSS/JS/Partial #11

csainty opened this issue Mar 19, 2012 · 2 comments

Comments

@csainty
Copy link
Member

csainty commented Mar 19, 2012

Firstly, .ascx? Ew :)
Had to rename to .cshtml and strip the declaration at the top.
I remove the webform renderer from my pipeline to speed it up.
Not sure what the best approach there is.
Perhaps include all common versions?

The CSS file seems to have a whole section referencing HTML elements that don't exist.
eg #langauge { }

The partial has some doubled up href attributes on the culture links.
More importantly though and related to my Documentation issue, it would be nicer if this could generate itself from a global list of supported cultures.

Javascript,
https://github.com/Code52/aspnet-internationalization/blob/master/src/Code52.i18n.MVC/NuSpec/Content/Scripts/Code52.i18n.js#L51

should that line be this.instance = ...

As I said in the chat room, I will try get some time to PR some of this stuff, at work atm and just brain dumping an issue list I put together while working with the library today.

@csainty csainty mentioned this issue Mar 21, 2012
@shiftkey
Copy link
Member

Firstly, .ascx? Ew :)

Done for compatibility and because (as you mention) both ViewEngines are loaded in MVC3 and up.

@shiftkey
Copy link
Member

I've accepted #13 so if there's anything you'd like to add or remove feel free to kick off a different discussion on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants