feat(gsoc'24): Deferred Contentions (#4882) #351
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -13,6 +13,7 @@ | |||
| } from './engine' | |||
| import Wire from './wire' | |||
| import { colors } from './themer/themer' | |||
| import ContentionMeta from './contention' | |||
Check failure
Code scanning / ESLint
disallow unused variables Error
| @@ -409,52 +410,69 @@ | |||
| return | |||
| } | |||
|
|
|||
| if (this.type == 0) { | |||
| // For input nodes, resolve its parents if they are resolvable at this point. | |||
| if (this.type == NODE_INPUT) { | |||
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments Error
| if (this.parent.isResolvable()) { | ||
| simulationArea.simulationQueue.add(this.parent) | ||
| } | ||
| } | ||
| else if (this.type == NODE_OUTPUT) { |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments Error
| } | ||
|
|
||
| // Fallthrough. NODE_INPUT propagates like a bitwidth checked NODE_INTERMEDIATE | ||
| case NODE_INTERMEDIATE: |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments Error
| default: | ||
| break; |
Check failure
Code scanning / ESLint
disallow fallthrough of `case` statements Error
| switch (node.type) { | ||
| // TODO: For an output node, a downstream value (value given by elements other than the parent) | ||
| // should be overwritten in contention check and should not cause contention. | ||
| case NODE_OUTPUT: |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments Error
updates from main repo
PR ref - #4882