Skip to content

Conversation

@niladrix719
Copy link
Member

updates from main repo

PR ref - #4882

@netlify
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit afec632
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/66b2293ebced3c00081f765e
😎 Deploy Preview https://deploy-preview-351--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

} from './engine'
import Wire from './wire'
import { colors } from './themer/themer'
import ContentionMeta from './contention'

Check failure

Code scanning / ESLint

disallow unused variables

'ContentionMeta' is defined but never used.

if (this.type == 0) {
// For input nodes, resolve its parents if they are resolvable at this point.
if (this.type == NODE_INPUT) {

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments

'NODE_INPUT' is not defined.
simulationArea.simulationQueue.add(this.parent)
}
}
else if (this.type == NODE_OUTPUT) {

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments

'NODE_OUTPUT' is not defined.
}

// Fallthrough. NODE_INPUT propagates like a bitwidth checked NODE_INTERMEDIATE
case NODE_INTERMEDIATE:

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments

'NODE_INTERMEDIATE' is not defined.
Comment on lines +474 to +475
default:
break;

Check failure

Code scanning / ESLint

disallow fallthrough of `case` statements

Expected a 'break' statement before 'default'.
switch (node.type) {
// TODO: For an output node, a downstream value (value given by elements other than the parent)
// should be overwritten in contention check and should not cause contention.
case NODE_OUTPUT:

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments

'NODE_OUTPUT' is not defined.
}

// Fallthrough. NODE_OUTPUT propagates like a contention checked NODE_INPUT
case NODE_INPUT:

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments

'NODE_INPUT' is not defined.
@gr455 gr455 merged commit 63e5e3c into CircuitVerse:main Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants