-
Notifications
You must be signed in to change notification settings - Fork 164
feat(gsoc'24): Deferred Contentions (#4882) #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } from './engine' | ||
| import Wire from './wire' | ||
| import { colors } from './themer/themer' | ||
| import ContentionMeta from './contention' |
Check failure
Code scanning / ESLint
disallow unused variables
|
|
||
| if (this.type == 0) { | ||
| // For input nodes, resolve its parents if they are resolvable at this point. | ||
| if (this.type == NODE_INPUT) { |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments
| simulationArea.simulationQueue.add(this.parent) | ||
| } | ||
| } | ||
| else if (this.type == NODE_OUTPUT) { |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments
| } | ||
|
|
||
| // Fallthrough. NODE_INPUT propagates like a bitwidth checked NODE_INTERMEDIATE | ||
| case NODE_INTERMEDIATE: |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments
| default: | ||
| break; |
Check failure
Code scanning / ESLint
disallow fallthrough of `case` statements
| switch (node.type) { | ||
| // TODO: For an output node, a downstream value (value given by elements other than the parent) | ||
| // should be overwritten in contention check and should not cause contention. | ||
| case NODE_OUTPUT: |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments
| } | ||
|
|
||
| // Fallthrough. NODE_OUTPUT propagates like a contention checked NODE_INPUT | ||
| case NODE_INPUT: |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments
updates from main repo
PR ref - #4882