fix(gsoc'24): updates and bug fixes from the main simulator #314

niladrix719 · 2024-05-16T14:58:19Z

Updates and Bug fixes from the main Simulator

netlify · 2024-05-16T14:58:35Z

✅ Deploy Preview for circuitverse ready!

Name	Link
🔨 Latest commit	`de610eb`
🔍 Latest deploy log	https://app.netlify.com/sites/circuitverse/deploys/66a9b333f8c3450008b9b8da
😎 Deploy Preview	https://deploy-preview-314--circuitverse.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/simulator/src/tutorials.js

src/simulator/src/node.js

-                simulationArea.simulationQueue.add(this.parent)
-            }
+        // For input nodes, resolve its parents if they are resolvable at this point.
+        if (this.type == NODE_INPUT) {


src/simulator/src/node.js

+            switch (node.type) {
+                // TODO: For an output node, a downstream value (value given by elements other than the parent)
+                // should be overwritten in contention check and should not cause contention.
+                case NODE_OUTPUT:


src/simulator/src/node.js

-                    )
-                }
+                // Fallthrough. NODE_OUTPUT propagates like a contention checked NODE_INPUT
+                case NODE_INPUT:


src/simulator/src/node.js

+                        break;
+                    }
+                // Fallthrough. NODE_INPUT propagates like a bitwidth checked NODE_INTERMEDIATE
+                case NODE_INTERMEDIATE:


src/simulator/src/node.js

        uniqueIdCounter++
        this.parent = parent
-        if (type != 2 && this.parent.nodeList !== undefined) {
+        if (type != NODE_INTERMEDIATE && this.parent.nodeList !== undefined) {


src/simulator/src/node.js

        this.refresh()

-        if (this.type == 2) {
+        if (this.type == NODE_INTERMEDIATE) {


src/simulator/src/node.js

     */
    converToIntermediate() {
-        this.type = 2
+        this.type = NODE_INTERMEDIATE


src/simulator/src/node.js

     */
    saveObject() {
-        if (this.type == 2) {
+        if (this.type == NODE_INTERMEDIATE) {


src/simulator/src/node.js

    updateScope(scope) {
        this.scope = scope
-        if (this.type == 2) this.parent = scope.root
+        if (this.type == NODE_INTERMEDIATE) this.parent = scope.root


src/simulator/src/node.js

            this.wasClicked = true
            this.prev = 'a'
-            if (this.type == 2) {
+            if (this.type == NODE_INTERMEDIATE) {


src/simulator/src/node.js

                }
            }
-            if (this.type == 2) {
+            if (this.type == NODE_INTERMEDIATE) {


src/simulator/src/node.js

        }

-        if (this.type == 2 && simulationArea.mouseDown == false) {
+        if (this.type == NODE_INTERMEDIATE && simulationArea.mouseDown == false) {


src/simulator/src/node.js

            ) {
                n = this.parent.scope.allNodes[i]
-                if (this.type == 2) {
+                if (this.type == NODE_INTERMEDIATE) {


src/simulator/src/node.js

                if (this.parent.scope.wires[i].checkConvergence(this)) {
                    var n = this
-                    if (this.type != 2) {
+                    if (this.type != NODE_INTERMEDIATE) {


src/simulator/src/data/save.js

…into vue-simulator-bug-fixes

tachyons · 2024-07-31T10:30:07Z

@niladrix719 I think this will undo some of the optimizations made by @JoshVarga . Why was this PR delayed ? you mentioned that all the updates from the legacy simulator are already copied, right ?

niladrix719 · 2024-07-31T12:48:13Z

@tachyons , I guess there was some miscommunication on my end. The PR was there way back but wasn't merged before

tachyons · 2024-07-31T12:56:55Z

@niladrix719 Could you create separate PRs to copy changes. PR can't be reviewed in this form. Also give highest priority for this.

niladrix719 · 2024-08-01T12:19:25Z

created Separate PRs - #345, #346, #347, #348, #349, #350, #351, #352, #353, #354, #355

niladrix719 added 8 commits May 16, 2024 19:25

feat: testbench tutorial added

4222d8b

fix: testbench buttons style updated

f8d4f5c

fix: small typos in function comments

2077fba

fix: corrected alignment of some element labels

bc4ad59

fix: issue of connect only r input crash simulator

24c8378

fix: capitalisation in simulator toolpit

4afab99

updated post assignment image

98f1a85

Fix circuit state flickering on autosave

af81d84

vedant-jain03 requested changes May 20, 2024

View reviewed changes

src/simulator/src/tutorials.js Outdated Show resolved Hide resolved

Deferred Contentions

2fbe017

github-advanced-security bot found potential problems May 28, 2024

View reviewed changes

niladrix719 added 3 commits May 28, 2024 17:20

Fix ControlledInverter - similar to tristate

df7099d

Reset nodes on contention

f615d70

Remove output contentions even on undef propagation

498d40f

github-advanced-security bot found potential problems May 28, 2024

View reviewed changes

niladrix719 added 2 commits May 28, 2024 19:33

Fix: SubCircuit i/o nodes not consistent with localscope i/o nodes

1d7bd99

Disable autosave

157e3b4

github-advanced-security bot found potential problems May 28, 2024

View reviewed changes

src/simulator/src/data/save.js Fixed Show fixed Hide fixed

niladrix719 added 3 commits May 28, 2024 20:14

fix: removal of duplicate and unused code

95cb2c4

fix: codeclimate issues

d8580cd

revert: some minor errs

3bff371

niladrix719 marked this pull request as ready for review June 1, 2024 15:36

added i18n for tutorials and some code refactoring

86d38eb

Arnabdaz requested review from Arnabdaz and vedant-jain03 June 2, 2024 09:59

refactored tutorial file

023484d

niladrix719 added the GSOC'24 PR's for GSoC'24 label Jul 25, 2024

niladrix719 added 2 commits July 31, 2024 09:14

Merge branch 'main' of https://github.com/niladrix719/cv-frontend-vue …

7f63a4a

…into vue-simulator-bug-fixes

updated

de610eb

tachyons requested a review from JoshVarga July 31, 2024 10:30

tachyons closed this Jul 31, 2024

Uh oh!

fix(gsoc'24): updates and bug fixes from the main simulator #314

fix(gsoc'24): updates and bug fixes from the main simulator #314

Uh oh!

Conversation

niladrix719 commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for circuitverse ready!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Check failure

Check failure

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Uh oh!

tachyons commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niladrix719 commented Jul 31, 2024

Uh oh!

tachyons commented Jul 31, 2024

Uh oh!

niladrix719 commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

niladrix719 commented May 16, 2024 •

edited

Loading

netlify bot commented May 16, 2024 •

edited

Loading

tachyons commented Jul 31, 2024 •

edited

Loading

niladrix719 commented Aug 1, 2024 •

edited

Loading