-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the Main simulator to dynamically load the Vue simulator #332
Closed
aryanndwi123
wants to merge
6
commits into
CircuitVerse:main
from
aryanndwi123:dynamic-version-loading
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a20ee7c
fix:add getConfiguredVersion to handle query parameter version(simver)
aryanndwi123 caea903
feat: add dynamic version loading function
aryanndwi123 c4e1169
feat: add main vue application entrypoint
aryanndwi123 e64648d
refactor: update entry point to use version-specific main.ts
aryanndwi123 3ac760c
fix:path for dynamic import of version
aryanndwi123 e5074eb
fix: changing single quotes to double
aryanndwi123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export const getConfiguredVersion = (): string => { | ||
const urlParams = new URLSearchParams(window.location.search); | ||
return urlParams.get('simver') || 'v0'; | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { getConfiguredVersion } from './config'; | ||
import { loadVersion } from './versionLoader'; | ||
|
||
const version = getConfiguredVersion(); | ||
loadVersion(version); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
export const loadVersion = (version: string): Promise<void> => { | ||
return import(`./${version}/src/main.ts`) | ||
.then(module => { | ||
console.log(`Loaded ${version}`); | ||
}) | ||
.catch(err => { | ||
console.error(`Failed to load ${version}`, err); | ||
}); | ||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Use of externally-controlled format string High