Enable the Main simulator to dynamically load the Vue simulator #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| console.log(`Loaded ${version}`); | ||
| }) | ||
| .catch(err => { | ||
| console.error(`Failed to load ${version}`, err); |
Check failure
Code scanning / CodeQL
Use of externally-controlled format string High
16 tasks
|
Closing since this is combined into another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR -
getConfiguredVersionhandles query parametersimverfor version selection.loadVersionfunction for dynamic loading of main.ts based on configured version.main.ts.Screenshots of the changes (If any) -
Final result :
(In the video, I labeled the navbar as v0 and v1 next to the project name for demonstration purposes, although these versions are not reflected in the actual code):
Screencast.from.2024-07-06.21-35-18.webm
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.