Skip to content

Allow comma separated SUBNET_FILTER values #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow comma separated SUBNET_FILTER values #719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/zinnia.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great! Could you please add a simple passing test for this feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the README needs to be updated

Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const maybeReportErrorToSentry = (/** @type {unknown} */ err) => {
}

const matchesSubnetFilter = (subnet) =>
SUBNET_FILTER === '' || subnet === SUBNET_FILTER
SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet);
SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet)


const capitalize = (str) => `${str.charAt(0).toUpperCase()}${str.slice(1)}`

Expand Down
Loading