Allow comma separated SUBNET_FILTER values #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to specify multiple allowed subnets in SUBNET_FILTER by separating them with comma. This will accept single subnet, such as SUBNET_FILTER=spark but also multiple subnets, such as SUBNET_FILTER=spark,arweave,walrus.
zipiju
requested review from
bajtos,
juliangruber,
pyropy and
NikolasHaimerl
as code owners
juliangruber
requested changes
Apr 11, 2025
| @@ -85,7 +85,7 @@ const maybeReportErrorToSentry = (/** @type {unknown} */ err) => { | |||
| } | |||
|
|
|||
| const matchesSubnetFilter = (subnet) => | |||
| SUBNET_FILTER === '' || subnet === SUBNET_FILTER | |||
| SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet); | |||
There was a problem hiding this comment.
Suggested change
| SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet); | |
| SUBNET_FILTER === '' || SUBNET_FILTER.split(',').includes(subnet) |
There was a problem hiding this comment.
Implementation looks great! Could you please add a simple passing test for this feature?
There was a problem hiding this comment.
Also the README needs to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify multiple allowed subnets in SUBNET_FILTER by separating them with comma. This will accept single subnet, such as SUBNET_FILTER=spark but also multiple subnets, such as SUBNET_FILTER=spark,arweave,walrus.