-
Notifications
You must be signed in to change notification settings - Fork 29
Set default python version 3.9 and fix strenum problem #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4eee56e
2a74765
449ee56
35dc8d2
db348a1
df7ed33
fe80984
d377dfa
080e948
be1393a
a343ce5
3be9ca7
3f12593
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,47 @@ | ||
| [build-system] | ||
| requires = ["setuptools"] | ||
| build-backend = "setuptools.build_meta" | ||
| requires = [ "setuptools" ] | ||
|
|
||
| [project] | ||
| name="recceiver" | ||
| name = "recceiver" | ||
| version = "1.8dev" | ||
| description = "recCeiver is a server component of the recsync protocol. It receives record updates from recsync clients (e.g., recCasters) and forwards them to a configurable backend such as ChannelFinder." | ||
| readme = "README.md" | ||
| authors = [ | ||
| {name = "Michael Davidsaver", email = "mdavidsaver@gmail.com"}, | ||
| { name = "Michael Davidsaver", email = "mdavidsaver@gmail.com" }, | ||
| ] | ||
| requires-python = ">=3.9" | ||
| classifiers = [ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove 3.6. - 3.8
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you not need 3.6 anymore? I'm happy to remove.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I read "default" in the PR description as planning to get rid of 3.6-3.8 It's up to the community what to do. I think there's value in making life easiest on the people using/deploying software in these open source projects. So it is good to keep support for older versions when it's not too much hassle and I would say keep 3.6. But I am fine moving to 3.9 too (RHEL 9 default) if no one else wants 3.6 support.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wary of going beyond the python supported versions https://devguide.python.org/versions/. 3.9 is already end of life. Wouldn't be surprised if that starts breaking the ci soon.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eh, I think the hassle is worth it to help the lab setups where there might just be one person trying to maintain all this EPICS software. But just my opinion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
| "Programming Language :: Python :: 3 :: Only", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", | ||
| ] | ||
| description="resync server" | ||
| version="1.5" | ||
| readme = "README.md" | ||
| requires-python = ">=3.6" | ||
| dependencies = [ | ||
jacomago marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "dataclasses; python_version < '3.7'", | ||
| "requests", | ||
| "twisted", | ||
| "channelfinder @ https://github.com/ChannelFinder/pyCFClient/archive/refs/tags/v3.0.0.zip" | ||
| "channelfinder @ https://github.com/ChannelFinder/pyCFClient/archive/refs/tags/v3.0.0.zip", | ||
| "dataclasses; python_version<'3.7'", | ||
| "requests", | ||
| "twisted", | ||
| ] | ||
|
|
||
| [project.optional-dependencies] | ||
| test = ["pytest", "testcontainers>=4"] | ||
|
|
||
| [project.urls] | ||
| Repository="https://github.com/mdavidsaver/recsync" | ||
| optional-dependencies.test = [ "pytest", "testcontainers>=4" ] | ||
| urls.Repository = "https://github.com/ChannelFinder/recsync" | ||
|
|
||
| [tool.setuptools] | ||
| packages = ["recceiver", "twisted.plugins"] | ||
| packages = [ "recceiver", "twisted.plugins" ] | ||
| include-package-data = true | ||
|
|
||
| [tool.setuptools.package-data] | ||
| twisted = ["plugins/recceiver_plugin.py"] | ||
|
|
||
| [tool.pytest.ini_options] | ||
| log_cli = true | ||
| log_cli_level = "DEBUG" | ||
| twisted = [ "plugins/recceiver_plugin.py" ] | ||
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| target-version = "py39" | ||
jacomago marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [tool.ruff.lint] | ||
| line-length = 120 | ||
| # Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default. | ||
| # Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or | ||
| # McCabe complexity (`C901`) by default. | ||
| select = ["E", "F", "I"] | ||
| lint.select = [ "E", "F", "I" ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| import logging | ||
| import random | ||
|
|
||
| from zope.interface import implementer | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is moving these imports necessary? same goes for all the other import changes
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Its from the latest version of ruff, the formatter must have changed to order the imports differently. |
||
|
|
||
| from twisted import plugin | ||
| from twisted.application import service | ||
| from twisted.internet import defer, pollreactor | ||
| from twisted.internet.error import CannotListenError | ||
| from twisted.python import log, usage | ||
| from zope.interface import implementer | ||
|
|
||
| from twisted import plugin | ||
|
|
||
| from .announce import Announcer | ||
| from .processors import ProcessorController | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| from requests import HTTPError | ||
|
|
||
| from twisted.internet.address import IPv4Address | ||
|
|
||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.