Set default python version 3.9 and fix strenum problem#135
Set default python version 3.9 and fix strenum problem#135
Conversation
jacomago
requested review from
anderslindho,
ralphlange,
shroffk,
simon-ess and
tynanford
|
I tried to get this check in the pre-commit, but adding all ruff lints wasn't enough, I had to add type checking... Which made the PR huge. So I'll stick with just this change for now. |
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
7dd8ea3 to
e3862b6
Compare
.github/workflows/server.yml
Outdated
There was a problem hiding this comment.
should remove 3.6 - 3.8 in the CI
| import logging | ||
| import random | ||
|
|
||
| from zope.interface import implementer |
There was a problem hiding this comment.
is moving these imports necessary? same goes for all the other import changes
There was a problem hiding this comment.
Its from the latest version of ruff, the formatter must have changed to order the imports differently.
| version="1.5" | ||
| readme = "README.md" | ||
| requires-python = ">=3.6" | ||
| classifiers = [ |
There was a problem hiding this comment.
Do you not need 3.6 anymore? I'm happy to remove.
There was a problem hiding this comment.
Ah, I read "default" in the PR description as planning to get rid of 3.6-3.8
It's up to the community what to do. I think there's value in making life easiest on the people using/deploying software in these open source projects. So it is good to keep support for older versions when it's not too much hassle and I would say keep 3.6. But I am fine moving to 3.9 too (RHEL 9 default) if no one else wants 3.6 support.
There was a problem hiding this comment.
I'm wary of going beyond the python supported versions https://devguide.python.org/versions/. 3.9 is already end of life. Wouldn't be surprised if that starts breaking the ci soon.
There was a problem hiding this comment.
Eh, I think the hassle is worth it to help the lab setups where there might just be one person trying to maintain all this EPICS software. But just my opinion
There was a problem hiding this comment.
+1
At ITER - at 1 million records with less than 10 of ~160 plant systems delivered - we are struggling to migrate everything to RHEL 8 (that uses Python 3.6 as standard).
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
e3862b6 to
2f39dc5
Compare
Co-authored-by: anderslindho <44849690+anderslindho@users.noreply.github.com>
jacomago
force-pushed
the
set-default-python-version-lower
branch
from
dfbfa02 to
3f12593
Compare
|
5 participants
No description provided.