-
Notifications
You must be signed in to change notification settings - Fork 2
Trajectory Optimization API #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for shooting methods
…th static goal and cost matrices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall API looks good, just missing a few tests.
I would add tests for:
- Computing the cost for quadratic with static goal (vs for loop)
- Computing the gradient and Hessian for the quadratic with static goal (vs autodiff)
- A smoke test for creating a
VanillaPredictiveSampler
and callingoptimize
(maybe not necessary depending on below) - Some sanity check that predictive sampling is doing the right thing. That could be a pendulum swingup example (should work even if the implementation isn't blazing fast yet) or a little unit test that shows the cost generally going down, or something else.
Agreed on the first two requested tests - those should be trivial to spin up. Sanity check of choice: randomly sample a batch of initial policies and also shoot them forward. pass those guesses to vanilla predictive sampling, which returns new trajectories that should be no worse than the guesses. verify this property in a test. TODO list:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a very generic and flexible API for trajectory optimization. As a specific instantiation, it also implements the extremely simple predictive sampling algorithm.