Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend dockerization #17151

Merged
merged 10 commits into from
Jan 27, 2025
Merged

frontend dockerization #17151

merged 10 commits into from
Jan 27, 2025

Conversation

devopsmatt
Copy link
Collaborator

@devopsmatt devopsmatt commented Jan 24, 2025

This PR introduces Dockerized frontend-react website running in a hardened, CVE-free container

Test Steps:

  1. Build DOCKER_BUILDKIT=1 docker build . --no-cache --progress=plain -f Dockerfile -t frontend:test
  2. Run docker run -p 127.0.0.1:8080:8080 frontend:test
  3. Test: the server will run on localhost:8080

Changes

  • Added frontend-react/Dockerfile

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@scott-aquia scott-aquia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR from a security perspective

@devopsmatt devopsmatt changed the title Experiment/frontend docker frontend dockerization Jan 24, 2025
Copy link
Contributor

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@devopsmatt devopsmatt force-pushed the experiment/frontend-docker branch from db7ef5e to feebe69 Compare January 27, 2025 19:13
Copy link
Contributor

⚠️ Broken Links ⚠️

https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


❌ /assets/xlsm/20241204_ReportStream-Mapping-Template.xlsm

Error: Internal link: Page error


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Copy link
Collaborator

@jpandersen87 jpandersen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! LGTM

@devopsmatt devopsmatt merged commit dddd6f4 into main Jan 27, 2025
29 of 30 checks passed
@devopsmatt devopsmatt deleted the experiment/frontend-docker branch January 27, 2025 22:13
@devopsmatt
Copy link
Collaborator Author

@jpandersen87 please run/test it locally, there are some notices in the build stage I am not qualified to determine the criticality of

@jpandersen87
Copy link
Collaborator

@jpandersen87 please run/test it locally, there are some notices in the build stage I am not qualified to determine the criticality of

Built the image locally and the warnings emitted during build look to be all currently expected ones (sass and output bundle chunk size).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants