-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend dockerization #17151
frontend dockerization #17151
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR from a security perspective
cf8c8fc
to
e4d1400
Compare
Branch deployed to Chromatic 🚀.
View via: |
078fc75
to
63ea444
Compare
db7ef5e
to
feebe69
Compare
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! LGTM
@jpandersen87 please run/test it locally, there are some notices in the build stage I am not qualified to determine the criticality of |
Built the image locally and the warnings emitted during build look to be all currently expected ones (sass and output bundle chunk size). |
This PR introduces Dockerized frontend-react website running in a hardened, CVE-free container
Test Steps:
DOCKER_BUILDKIT=1 docker build . --no-cache --progress=plain -f Dockerfile -t frontend:test
docker run -p 127.0.0.1:8080:8080 frontend:test
localhost:8080
Changes
frontend-react/Dockerfile