Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local validation of dockerization of FE to eliminate 404 error #17547

Open
2 tasks
chris-kuryak opened this issue Mar 11, 2025 · 2 comments
Open
2 tasks

Local validation of dockerization of FE to eliminate 404 error #17547

chris-kuryak opened this issue Mar 11, 2025 · 2 comments
Assignees
Labels
engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team

Comments

@chris-kuryak
Copy link
Collaborator

chris-kuryak commented Mar 11, 2025

Problem statement

DevOps has finished the dockerization of the FE to hopefully eliminate the 404 error that happens on every page load. But to confirm and finish the changes, FE needs to validate the changes locally.

What you need to know

Acceptance criteria

  • App runs locally using the new dockerization of FE
  • Update the ticket estimate (if needed)
@chris-kuryak chris-kuryak added engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team labels Mar 11, 2025
@chris-kuryak chris-kuryak changed the title Copy of Finish validation of the new dockerization of FE to eliminate 404 error Local validation of dockerization of FE to eliminate 404 error Mar 11, 2025
@etanb
Copy link
Collaborator

etanb commented Mar 24, 2025

Reference for instructions: #17151

  1. Confirmed that the app, via Dockerization, technically launches.
  2. HOWEVER, it does not work as a local dev environment. The current Dockerfile launches it in production mode and is not suitable for local development.
  3. We have one Dockerfile. We'd either need multiple Dockerfiles, one per env or local development process, or a new approach, ie, a Dockerfile for production, a Dockerfile for local development that allows us to input commands at runtime to utilize the various local development runtimes we need ie, with CSP, without overlays etc. Example of the various options we pass to our local development: https://github.com/CDCgov/prime-reportstream/blob/main/frontend-react/package.json#L51-L91
  4. Who maintains these Dockerfiles? We'd have to make sure we document this as well as completely update our F/E README instructions.

In summary, if this ticket's main goal was to check that the new workflow works in production, then we're good to go, but when I talked to Matt from Devops, it seemed like the main goal was to have parity Production/Local Development, which means we'd have a long way to go make this viable and may need a separate ticket.

cc @chris-kuryak @devopsmatt

@etanb
Copy link
Collaborator

etanb commented Mar 25, 2025

@devopsmatt is there another ticket that we can track for this to be deployed to used for production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team
Projects
None yet
Development

No branches or pull requests

3 participants