Use ACM certificate with ALB instead of Cloudfront #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclyde
requested review from
marycrawford,
rin-skylight and
DanPaseltiner
DanPaseltiner
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
This is awesome! I do wonder if dibbs.cloud is the correct domain name.
- It does not distinguish between our Azure and AWS deployments.
- It does not indicate that this is hosted in Skylight owned dev environment.
What about something like dibbs-aws-skylight and dibbs-azure-skylight? I think this can sorted out in a future PR and might require some additional discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Use ACM certificate with ALB instead of Cloudfront. This terraform provisions a certificate for dibbs.cloud (or any domain, but I purchased dibbs.cloud on our AWS account) and use it with the ALB for HTTPS. This removes the need for a Cloudfront distribution, and makes setting up authentication with Cognito a little easier. It also gives us a nice hostname for our services!
https://dibbs.cloud/fhir-converter
https://dibbs.cloud/message-parser
https://dibbs.cloud/orchestration, etc.