Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cognito for authentication #57

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Add Cognito for authentication #57

merged 9 commits into from
Mar 13, 2024

Conversation

nickclyde
Copy link
Member

@nickclyde nickclyde commented Feb 28, 2024

PULL REQUEST

Summary

Adds Cognito so that our endpoints are protected by an authentication check.

Related Issue

Fixes #1311
Depends on #55
Screenshot 2024-02-28 at 3 38 33 PM
Depends on #67

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting to have auth enable. I know this turned into a long slog. I have two questions.

  1. Could we add some documentation for how an engineer could generate a bearer token to include with a request from their local to avoid the sign in screen? I'm thinking about demos from Postman/Insomnia on folks' locals.

  2. As continue to build out some UI components for DIBBs we will likely need to give access to CDC stakeholders and potential pilot participants to let them play around to experience the product we are building. Is there a way we could generate some creds that could be shared to allow access? Obviously this is NOT what we would do on production instance. I was just in a call with some stakeholders yesterday where they asked if we could get the FHIR client @m-goggins and I built at the connectathon hosted for publicly for others to be able to play and see what we built.

Base automatically changed from nickclyde/alb-acm to main February 29, 2024 19:57

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde
Copy link
Collaborator

@marycrawford marycrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Copy link
Collaborator

@rin-skylight rin-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde
@nickclyde nickclyde changed the base branch from main to nickclyde/fixes-for-s3 March 11, 2024 21:50

Verified

This commit was signed with the committer’s verified signature.
nickclyde Nick Clyde
Base automatically changed from nickclyde/fixes-for-s3 to main March 13, 2024 17:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nickclyde nickclyde merged commit 0f78280 into main Mar 13, 2024
4 checks passed
@nickclyde nickclyde deleted the nickclyde/cognito branch March 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants