-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cognito for authentication #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting to have auth enable. I know this turned into a long slog. I have two questions.
-
Could we add some documentation for how an engineer could generate a bearer token to include with a request from their local to avoid the sign in screen? I'm thinking about demos from Postman/Insomnia on folks' locals.
-
As continue to build out some UI components for DIBBs we will likely need to give access to CDC stakeholders and potential pilot participants to let them play around to experience the product we are building. Is there a way we could generate some creds that could be shared to allow access? Obviously this is NOT what we would do on production instance. I was just in a call with some stakeholders yesterday where they asked if we could get the FHIR client @m-goggins and I built at the connectathon hosted for publicly for others to be able to play and see what we built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PULL REQUEST
Summary
Adds Cognito so that our endpoints are protected by an authentication check.
Related Issue
Fixes #1311

Depends on #55
Depends on #67