Add option to azure login action with service principals and az acr login intwostep-container-build
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service principals
dylanhmorris
commented
Feb 11, 2025
dylanhmorris
changed the title
az acr login and the azure login action with service principalsaz acr login and azure login action with service principals to twostep-container-build
dylanhmorris
changed the title
az acr login and azure login action with service principals to twostep-container-buildaz acr login intwostep-container-build
|
Awesome, thanks for the contribution, @dylanhmorris! We should probably add a test using |
Added a test, but this repo will now need the self-hosted runners set up. We can use the STF service principal for now, but in the long run we should probably have a service principal for CFA actions itself. |
gvegayon
reviewed
Feb 12, 2025
|
Alright, I just made a small tweak to reflect the new version of the action (1.2.1 vs 1.2.0). We can deal with adding a self-hosted runner later. I will approve, merge, and release so you can start using this ASAP in pyrenew. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a more robust approach. It should be more secure and should also help with CDCgov/pyrenew-hew#321
Also makes the docker login action inputs optional, since they are only needed and used if you go that route. I also see some argument that the action shouldn't attempt to log in at all, and the user should handle that upstream in their workflow.