Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SP authentication in containers.yaml #341

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

dylanhmorris
Copy link
Contributor

@dylanhmorris dylanhmorris commented Feb 11, 2025

Instead of a hard-coded account password.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.30%. Comparing base (d8534e9) to head (28ff179).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   25.30%   25.30%           
=======================================
  Files          22       22           
  Lines        1648     1648           
=======================================
  Hits          417      417           
  Misses       1231     1231           
Flag Coverage Δ
hewr 41.68% <ø> (ø)
pipelines 5.15% <ø> (ø)
pyrenew_hew 27.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris dylanhmorris marked this pull request as ready for review February 11, 2025 15:52
@dylanhmorris dylanhmorris marked this pull request as draft February 11, 2025 18:22
@dylanhmorris dylanhmorris marked this pull request as ready for review February 12, 2025 22:01
@damonbayer damonbayer self-requested a review February 12, 2025 22:29
@damonbayer damonbayer enabled auto-merge (squash) February 12, 2025 22:30
@damonbayer damonbayer merged commit 800a23f into main Feb 12, 2025
15 checks passed
@damonbayer damonbayer deleted the dylanhmorris-sp-authentication branch February 12, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants