-
Notifications
You must be signed in to change notification settings - Fork 299
fix(coins): Validate amount as integer type in sendCoins #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ranjna-G
merged 1 commit into
master
from
WIN-4726-improve-error-msg-for-invalid-amount-withdrawal
May 21, 2025
Merged
fix(coins): Validate amount as integer type in sendCoins #6138
Ranjna-G
merged 1 commit into
master
from
WIN-4726-improve-error-msg-for-invalid-amount-withdrawal
May 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84b984f to
7f91ed6
Compare
shashankms288
previously approved these changes
May 19, 2025
Contributor
shashankms288
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OttoAllmendinger
requested changes
May 19, 2025
Contributor
OttoAllmendinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see JIRA
arvind-bg
reviewed
May 19, 2025
7f91ed6 to
061641d
Compare
Improve error message for integer validation in sendCoins functionality Ticket: WIN-4726
061641d to
c571b13
Compare
OttoAllmendinger
approved these changes
May 20, 2025
shashankms288
approved these changes
May 20, 2025
Contributor
shashankms288
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FloBitGo
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message for the same
Ticket: WIN-4726