fix(express): validate amount as integer type in sendCoins

Improve error message for integer validation in sendCoins functionality

Ticket: WIN-4726

Author: Ranjna-G

modules/bitgo/test/v2/unit/wallet.ts

@@ -4893,4 +4893,46 @@ describe('V2 Wallet:', function () {
       await wallet.approveErc20Token(walletPassphrase, tokenName).should.be.rejectedWith(sendError);
     });
   });
+
+  describe('Amount Validation for sendCoins', function () {
+    let wallet;
+    let params;
+
+    before(function () {
+      const basecoin = bitgo.coin('tbtc');
+      wallet = new Wallet(bitgo, basecoin, {
+        id: '5b34252f1bf349930e34020a',
+        coin: 'tbtc',
+        keys: ['5b3424f91bf349930e340175'],
+      });
+      params = {
+        address: '2N4Xz4itCdKKUREiytEJ1KGPoEnKHmJUIwq',
+        walletPassphrase: 'test123',
+      };
+    });
+
+    it('should reject decimal amounts in send coins', async function () {
+      params.amount = 150000000.55;
+
+      await wallet
+        .send(params)
+        .should.be.rejectedWith('invalid argument for amount - Integer greater than zero or numeric string expected');
+    });
+
+    it('should reject negative amount in send coins', async function () {
+      params.amount = '-12';
+
+      await wallet
+        .send(params)
+        .should.be.rejectedWith('invalid argument for amount - Integer greater than zero or numeric string expected');
+    });
+
+    it('should reject zero in send coins', async function () {
+      params.amount = '0';
+
+      await wallet
+        .send(params)
+        .should.be.rejectedWith('invalid argument for amount - Integer greater than zero or numeric string expected');
+    });
+  });
 });

modules/express/package.json

@@ -59,6 +59,7 @@
     "@bitgo/public-types": "5.1.0",
     "@bitgo/sdk-lib-mpc": "^10.2.0",
     "@bitgo/sdk-test": "^8.0.84",
+    "@bitgo/sdk-api": "^1.62.3",
     "@types/argparse": "^1.0.36",
     "@types/body-parser": "^1.17.0",
     "@types/express": "4.17.13",

modules/express/test/unit/clientRoutes/sendcoins.ts

@@ -0,0 +1,27 @@
+import 'should';
+import { BitGoAPI } from '@bitgo/sdk-api';
+
+describe('Wallet Send Coins Amount Validation', () => {
+  let bitgo;
+  let wallet;
+  const walletId = 'TEST_WALLET_ID';
+
+  before(async function () {
+    bitgo = new BitGoAPI({ env: 'test' });
+
+    // Create a wallet using newWalletObject
+    wallet = bitgo.newWalletObject({ id: walletId });
+  });
+
+  it('should throw an error when sending decimal amount', async function () {
+    try {
+      await wallet.sendCoins({
+        address: 'TEST_WALLET1_ADDRESS',
+        amount: 0.5, // Decimal amount
+        walletPassphrase: 'dummy',
+      });
+    } catch (error) {
+      error.message.should.equal('invalid argument for amount - Integer expected');
+    }
+  });
+});

modules/sdk-api/src/v1/wallet.ts

@@ -1096,9 +1096,8 @@ Wallet.prototype.confirmInviteAndShareWallet = function (params, callback) {
 Wallet.prototype.sendCoins = function (params, callback) {
   params = params || {};
   common.validateParams(params, ['address'], ['message'], callback);
-
-  if (!_.isNumber(params.amount)) {
-    throw new Error('invalid argument for amount - number expected');
+  if (!_.isInteger(params.amount)) {
+    throw new Error('invalid argument for amount - Integer expected');
   }
 
   params.recipients = {};

modules/sdk-core/src/bitgo/wallet/wallet.ts

@@ -2408,13 +2408,17 @@ export class Wallet implements IWallet {
     const coin = this.baseCoin;
 
     const amount = new BigNumber(params.amount);
-    if (amount.isNegative()) {
-      throw new Error('invalid argument for amount - positive number greater than zero or numeric string expected');
-    }
 
-    if (!coin.valuelessTransferAllowed() && amount.isZero()) {
-      throw new Error('invalid argument for amount - positive number greater than zero or numeric string expected');
-    }
+    const isAmountNegative = amount.isNegative();
+    const isAmountZero = amount.isZero();
+    const isAmountDecimal = !amount.isInteger();
+
+    _.some([isAmountNegative, !coin.valuelessTransferAllowed() && isAmountZero, isAmountDecimal], (condition) => {
+      if (condition) {
+        throw new Error('invalid argument for amount - Integer greater than zero or numeric string expected');
+      }
+    });
+
     const recipients: SendManyOptions['recipients'] = [
       {
         address: params.address,