Add support for Tron staking #5972

abhijit0943 · 2025-04-16T11:50:56Z

Adding support for freeze and vote transactions for validating the transaction built by the WP (which calls the respective rpc methods via IMS)

modules/sdk-coin-trx/src/lib/utils.ts

modules/sdk-coin-trx/test/unit/freezeBuilder.ts

modules/sdk-coin-trx/test/unit/voteBuilder.ts

modules/sdk-coin-trx/src/lib/utils.ts

modules/sdk-coin-trx/src/lib/freezeBuilder.ts

gianchandania

Am yet to fully review this, but I think we should do the tx building here in SDK just like we do for all coins

modules/sdk-coin-trx/src/lib/enum.ts

modules/sdk-coin-trx/src/lib/freezeBuilder.ts

gianchandania · 2025-05-08T05:47:37Z

modules/sdk-coin-trx/src/lib/freezeBuilder.ts

+    this.transaction.setTransactionType(this.transactionType);
+  }
+
+  validateTransaction(transaction: Transaction | TransactionReceipt): void {


Why the type is transaction: Transaction | TransactionReceipt, why not just transaction: Transaction as in case of validateTransaction in other builder classes like ContractCallBuilder and TransactionBuilder

For flexibility, because 2 paths are being checked: if its a txn object or if it's raw txn data

Where are we calling this from, can you point me to that? Is the type there Transaction | TransactionReceipt

In the tests (resources file), the type is TransactionReceipt, but since we are overriding the method from the base class which uses Transaction object for validation, we would need to have Transaction | TransactionReceipt

modules/sdk-coin-trx/test/unit/freezeBuilder.ts

gianchandania · 2025-05-09T09:37:10Z

modules/sdk-coin-trx/src/lib/wrappedBuilder.ts

@@ -10,6 +10,8 @@ import { ContractType } from './enum';
 import { ContractCallBuilder } from './contractCallBuilder';
 import { TransactionReceipt } from './iface';
 import { TokenTransferBuilder } from './tokenTransferBuilder';
+import { FreezeTransactionBuilder } from './freezeBuilder';


import { FreezeBalanceTxBuilder } from './freezeBalanceTxBuilder';

gianchandania · 2025-05-09T09:37:26Z

modules/sdk-coin-trx/src/lib/wrappedBuilder.ts

@@ -10,6 +10,8 @@ import { ContractType } from './enum';
 import { ContractCallBuilder } from './contractCallBuilder';
 import { TransactionReceipt } from './iface';
 import { TokenTransferBuilder } from './tokenTransferBuilder';
+import { FreezeTransactionBuilder } from './freezeBuilder';
+import { VoteBuilder } from './voteBuilder';


import { VoteWitnessTxBuilder } from './voteWitnessTxBuilder';

gianchandania · 2025-05-09T09:39:29Z

modules/sdk-coin-trx/src/lib/wrappedBuilder.ts

+   * @param {Transaction} [tx] The transaction to initialize builder
+   * @returns {FreezeTransactionBuilder} The specific freeze balance builder
+   */
+  getFreezeBuilder(tx?: TransactionReceipt | string): FreezeTransactionBuilder {


getFreezeBalanceTxBuilder

gianchandania · 2025-05-09T09:40:05Z

modules/sdk-coin-trx/src/lib/wrappedBuilder.ts

+   * @param {Transaction} [tx] The transaction to initialize builder
+   * @returns {VoteBuilder} The specific vote witness builder
+   */
+  getVoteBuilder(tx?: TransactionReceipt | string): VoteBuilder {


getVoteWitnessBuilder

gianchandania · 2025-05-09T09:54:25Z

modules/sdk-coin-trx/src/lib/iface.ts

+/**
+ * Vote data in a vote transaction
+ */
+export interface VoteData {


export interface VoteWitnessData

gianchandania · 2025-05-09T11:30:17Z

modules/sdk-coin-trx/test/unit/voteBuilder.ts

+import { VoteBuilder } from '../../src/lib/voteBuilder';
+import { validVoteUnsignedTx } from '../resources';
+import { getBuilder } from '../../src/lib/builder';
+import { TransactionType } from '@bitgo/sdk-core';


external imports should be on top for better readability

gianchandania · 2025-05-09T11:30:35Z

modules/sdk-coin-trx/test/unit/freezeBuilder.ts

+import { FreezeTransactionBuilder, FreezeResource } from '../../src/lib/freezeBuilder';
+import { validFreezeUnsignedTx } from '../resources';
+import { getBuilder } from '../../src/lib/builder';
+import { TransactionType } from '@bitgo/sdk-core';


external imports should be on top for better readability

gianchandania · 2025-05-09T11:30:44Z

modules/sdk-coin-trx/test/unit/voteBuilder.ts

+
+describe('Tron VoteBuilder', function () {
+  let voteBuilder: VoteBuilder;
+  let wrappedBuilder;


assign type

gianchandania · 2025-05-09T11:30:55Z

modules/sdk-coin-trx/test/unit/voteBuilder.ts

+    wrappedBuilder = getBuilder('ttrx');
+    // Get VoteBuilder from the wrapped builder
+    voteBuilder = wrappedBuilder.getVoteBuilder();
+  });


this should be in before

modules/sdk-coin-trx/test/unit/voteBuilder.ts

gianchandania · 2025-05-09T11:41:43Z

modules/sdk-coin-trx/src/lib/freezeBuilder.ts

+  ENERGY = 'ENERGY',
+}
+
+interface RawContract {


RawFreezeContract

Ticket: SC-1632

abhijit0943 force-pushed the SC-1632 branch 10 times, most recently from f32b13c to 8325c1f Compare April 21, 2025 05:56

abhijit0943 requested review from Vijay-Jagannathan and removed request for Vijay-Jagannathan April 21, 2025 06:02

abhijit0943 force-pushed the SC-1632 branch 2 times, most recently from 6d8f7a6 to b6a3a71 Compare April 22, 2025 05:55

abhijit0943 changed the title ~~Adding freezeBuilder~~ Adding freezeBuilder and voteBuilder Apr 22, 2025

noel-bitgo reviewed Apr 23, 2025

View reviewed changes

modules/sdk-coin-trx/src/lib/utils.ts Outdated Show resolved Hide resolved

noel-bitgo reviewed Apr 23, 2025

View reviewed changes

modules/sdk-coin-trx/test/unit/freezeBuilder.ts Outdated Show resolved Hide resolved

modules/sdk-coin-trx/test/unit/voteBuilder.ts Outdated Show resolved Hide resolved

abhijit0943 requested a review from noel-bitgo April 29, 2025 09:38

Vijay-Jagannathan reviewed May 2, 2025

View reviewed changes

modules/sdk-coin-trx/src/lib/utils.ts Outdated Show resolved Hide resolved

modules/sdk-coin-trx/src/lib/freezeBuilder.ts Outdated Show resolved Hide resolved

Vijay-Jagannathan mentioned this pull request May 2, 2025

Adding unfreeze and withdraw for tron unstaking #6013

Draft

abhijit0943 force-pushed the SC-1632 branch from b6a3a71 to 2339d7c Compare May 5, 2025 07:39

abhijit0943 marked this pull request as ready for review May 5, 2025 08:05

abhijit0943 requested a review from a team as a code owner May 5, 2025 08:05

abhijit0943 removed the request for review from noel-bitgo May 5, 2025 08:05

abhijit0943 marked this pull request as draft May 5, 2025 08:06

abhijit0943 requested a review from Vijay-Jagannathan May 5, 2025 08:07

gianchandania reviewed May 8, 2025

View reviewed changes

abhijit0943 force-pushed the SC-1632 branch from 2339d7c to d046a26 Compare May 8, 2025 10:52

abhijit0943 removed the request for review from Vijay-Jagannathan May 9, 2025 09:48

gianchandania reviewed May 9, 2025

View reviewed changes

abhijit0943 force-pushed the SC-1632 branch 6 times, most recently from 90d066b to 425ff10 Compare May 11, 2025 17:27

Vijay-Jagannathan changed the title ~~Adding freezeBuilder and voteBuilder~~ Add support for Tron staking May 13, 2025

Vijay-Jagannathan force-pushed the SC-1632 branch 11 times, most recently from 08d4521 to 69134ff Compare May 19, 2025 18:07

feat(sdk-coin-trx): add stake support (freeze and vote)

bbe7aeb

Ticket: SC-1632

Vijay-Jagannathan force-pushed the SC-1632 branch from 69134ff to bbe7aeb Compare May 19, 2025 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Tron staking #5972

Add support for Tron staking #5972

abhijit0943 commented Apr 16, 2025 •

edited

Loading

gianchandania left a comment

gianchandania May 8, 2025

abhijit0943 May 8, 2025

gianchandania May 9, 2025

abhijit0943 May 9, 2025 •

edited

Loading

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

gianchandania May 9, 2025

Add support for Tron staking #5972

Are you sure you want to change the base?

Add support for Tron staking #5972

Conversation

abhijit0943 commented Apr 16, 2025 • edited Loading

gianchandania left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhijit0943 May 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhijit0943 commented Apr 16, 2025 •

edited

Loading

abhijit0943 May 9, 2025 •

edited

Loading