Skip to content

Add support for Tron staking #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Add support for Tron staking #5972

merged 1 commit into from
May 21, 2025

Conversation

abhijit0943
Copy link
Contributor

@abhijit0943 abhijit0943 commented Apr 16, 2025 •
edited by Vijay-Jagannathan
Loading

TICKET: SC-1632

Changes

  • Adds support for building freeze and vote txns in the SDK along with necessary validations
  • Adds the necessary protobuf generated contracts (V2 contracts weren't present previously) which are needed for freeze/unfreeze (unfreeze txn building will be part of a different PR, but this PR introduces the contracts)
  • Unifies some common methods in transaction builder instead of duplicating them in every builder (any further code duplication cleanup will be done separately in a followup)

@abhijit0943 abhijit0943 force-pushed the SC-1632 branch 10 times, most recently from f32b13c to 8325c1f Compare April 21, 2025 05:56
@abhijit0943 abhijit0943 requested review from Vijay-Jagannathan and removed request for Vijay-Jagannathan April 21, 2025 06:02
@abhijit0943 abhijit0943 force-pushed the SC-1632 branch 2 times, most recently from 6d8f7a6 to b6a3a71 Compare April 22, 2025 05:55
@abhijit0943 abhijit0943 changed the title Adding freezeBuilder Adding freezeBuilder and voteBuilder Apr 22, 2025
noel-bitgo
noel-bitgo reviewed Apr 23, 2025
View reviewed changes
noel-bitgo
noel-bitgo reviewed Apr 23, 2025
View reviewed changes
@abhijit0943 abhijit0943 requested a review from noel-bitgo April 29, 2025 09:38
Vijay-Jagannathan
Vijay-Jagannathan reviewed May 2, 2025
View reviewed changes
@Vijay-Jagannathan Vijay-Jagannathan mentioned this pull request May 2, 2025
Merged
@abhijit0943 abhijit0943 marked this pull request as ready for review May 5, 2025 08:05
@abhijit0943 abhijit0943 requested a review from a team as a code owner May 5, 2025 08:05
@abhijit0943 abhijit0943 removed the request for review from noel-bitgo May 5, 2025 08:05
@abhijit0943 abhijit0943 marked this pull request as draft May 5, 2025 08:06
gianchandania
gianchandania reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am yet to fully review this, but I think we should do the tx building here in SDK just like we do for all coins

@abhijit0943 abhijit0943 removed the request for review from Vijay-Jagannathan May 9, 2025 09:48
@abhijit0943 abhijit0943 force-pushed the SC-1632 branch 3 times, most recently from 90d066b to 425ff10 Compare May 11, 2025 17:27
@Vijay-Jagannathan Vijay-Jagannathan changed the title Adding freezeBuilder and voteBuilder Add support for Tron staking May 13, 2025
@Vijay-Jagannathan Vijay-Jagannathan force-pushed the SC-1632 branch 20 times, most recently from 97800cd to 453754d Compare May 20, 2025 06:14
@Vijay-Jagannathan Vijay-Jagannathan marked this pull request as ready for review May 21, 2025 04:30
@Vijay-Jagannathan Vijay-Jagannathan merged commit 39cae57 into master May 21, 2025
13 checks passed
@ppongbitgo ppongbitgo deleted the SC-1632 branch June 21, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianchandania gianchandania gianchandania left review comments

@Vijay-Jagannathan Vijay-Jagannathan Vijay-Jagannathan left review comments

@noel-bitgo noel-bitgo noel-bitgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhijit0943 @gianchandania @noel-bitgo @Vijay-Jagannathan