Adding unfreeze and withdraw for tron unstaking#6013
Conversation
abhijit0943
force-pushed
the
SC-1670
branch
5 times, most recently
from
5ebf190 to
0ed67c2
Compare
abhijit0943
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gianchandania
left a comment
gianchandania
left a comment
There was a problem hiding this comment.
Please refer to other PR and address similar comments in this PR
| /** | ||
| * Valid resource types for Tron freezing and unfreezing | ||
| */ | ||
| export enum TronResource { |
There was a problem hiding this comment.
This can be used in freeze PR as well
| const withdrawValues = (rawData.contract[0] as WithdrawExpireUnfreezeContract).parameter.value; | ||
| output = { | ||
| address: withdrawValues.owner_address, | ||
| value: '0', // no value field |
There was a problem hiding this comment.
Just trying to understand, why this is 0 in StakingWithdraw type?
There was a problem hiding this comment.
Just set as a placeholder as we don't provide any explicit value for the amount to be withdrawn
Vijay-Jagannathan
force-pushed
the
SC-1670
branch
4 times, most recently
from
220d2ba to
8c91851
Compare
Vijay-Jagannathan
force-pushed
the
SC-1670
branch
from
8c91851 to
bf49450
Compare
noel-bitgo
left a comment
noel-bitgo
left a comment
There was a problem hiding this comment.
test to build from raw?
some of the test cases do build the txn and then do .from to build from raw and assert on whether they are same or not |
oh my bad, looks good |
4 participants
TICKET: SC-1670
Adding support for unfreeze and withdrawexpireunfreeze txns