Skip to content

fix(modules.symlinkScript): replace replace with free replacement #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BirdeeHub merged 1 commit into from
May 18, 2026
Merged

fix(modules.symlinkScript): replace replace with free replacement #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/symlinkScript/checks/filesToPatch.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ test "filesToPatch-test" {
package = pkgs.hello;
wrapperImplementation = "binary";
wrapperVariants.fileToBePatched.exePath = "bin/hello"; # <- not the main one, the outer wrapper module will thus not wrap it automatically.
flags."--greeting" = "Hello, ${placeholder "out"}";
flags."--greeting" = "Hello,\0 ${placeholder "out"}";
}
)
];
Expand Down
4 changes: 2 additions & 2 deletions modules/symlinkScript/module.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@
echo "Patching $file"
# Remove symlink and create a real file with patched content
rm "$file"
# Use replace-literal which works for both text and binary files
${pkgs.replace}/bin/replace-literal "$oldPath" "$newPath" < "$target" > "$file"
# Use gnused explicitly which works for both text and binary files
${pkgs.gnused}/bin/sed "s|$oldPath|$newPath|g" "$target" > "$file"
# Preserve permissions
chmod --reference="$target" "$file"
fi
Expand Down