fix(modules.symlinkScript): replace replace with free replacement#537
Merged
Conversation
pkgs.replace was marked unfree. Due to some fumbling with handling of PRs, mostly on my part, I am going to do it. Credit to @Elias-Graf and @MakeShiftArtist for this change Co-authored-by: Elias Graf <Elias-Graf@users.noreply.github.com> Co-authored-by: MakeShiftArtist <MakeShiftArtist@users.noreply.github.com>
Contributor
|
Thank you for your work @BirdeeHub |
Owner
Author
|
Thank you for helping out! I have allowUnfree on all the stuff in my configs, I literally did not notice. |
Contributor
|
I'm explicitly using (yes I should cleanup the getName :D): nixpkgs.config.allowUnfreePredicate =
pkg:
builtins.elem (lib.getName pkg) [
(lib.getName pkgs.android-studio)
(lib.getName pkgs.steam)
(lib.getName pkgs.steam-unwrapped)
];To prevent new packages from sneeking in ^^.
No worries, I love to learn new stuff! Maybe I can contribute something next time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkgs.replace was marked unfree. Due to some fumbling with handling of PRs, on my part, I am going to do it, because I also updated the tests for it earlier.
#525
#532
Credit to @Elias-Graf and @MakeShiftArtist for this change
closes #536