Rc 1 #1851
+76,672
−132,849
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: test season pass | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - "contracts/**" | ||
| - "client/**" | ||
| - "**/manifest.json" | ||
| - "discord-bot/**" | ||
| - "config/**" | ||
| - ".github/**" | ||
| - "pnpm-lock.yaml" | ||
|
|
||
| env: | ||
| SCARB_VERSION: v2.8.2 | ||
|
|
||
| jobs: | ||
| test-season-pass: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: software-mansion/setup-scarb@v1 | ||
| with: | ||
| tool-versions: season_pass/contracts/.tool-versions | ||
| - uses: foundry-rs/setup-snfoundry@v3 | ||
| with: | ||
| tool-versions: season_pass/contracts/.tool-versions | ||
|
Comment on lines
+17
to
+27
There was a problem hiding this comment. 💡 Codebase verification 🛠️ Refactor suggestion Update actions and pin the Ubuntu version. The current workflow uses
🔗 Analysis chainConsider updating actions and pinning the Ubuntu version. The job setup looks good overall, but there are a few suggestions for improvement:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- runs-on: ubuntu-latest
+ runs-on: ubuntu-22.04
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the existence and content of the .tool-versions file
# Test: Check if the file exists and display its content
if [ -f "season_pass/contracts/.tool-versions" ]; then
echo "Content of .tool-versions file:"
cat "season_pass/contracts/.tool-versions"
else
echo "Error: .tool-versions file not found"
exit 1
fi
Length of output: 201 Script: #!/bin/bash
# Description: Check the version of actions/checkout in the workflow file
# Use grep to find the actions/checkout version
echo "Checking actions/checkout version:"
grep 'uses: actions/checkout@' .github/workflows/test-season-pass.yml || { echo "actions/checkout not found"; exit 1; }
Length of output: 184 Script: #!/bin/bash
# Description: Verify if the Ubuntu version is pinned in the workflow file
# Check if runs-on is set to ubuntu-latest
echo "Checking runs-on configuration:"
if grep -q 'runs-on: ubuntu-latest' .github/workflows/test-season-pass.yml; then
echo "runs-on is set to ubuntu-latest. Consider pinning to a specific version like ubuntu-22.04."
exit 1
else
echo "runs-on is pinned to a specific Ubuntu version."
fi
Length of output: 346 |
||
| - run: scarb build | ||
| working-directory: season_pass/contracts | ||
| - run: snforge test | ||
| working-directory: season_pass/contracts | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| node_modules | ||
| target | ||
| .snfoundry_cache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| scarb 2.7.0 | ||
| dojo 1.0.0-alpha.16 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using the SCARB_VERSION environment variable.
The
SCARB_VERSIONenvironment variable is defined but not explicitly used in the workflow steps. To ensure consistency and make version updates easier, consider using this variable in the setup steps.Update the Scarb setup step to use the environment variable:
- uses: software-mansion/setup-scarb@v1 with: + scarb-version: ${{ env.SCARB_VERSION }} tool-versions: season_pass/contracts/.tool-versions📝 Committable suggestion