Rc 1 #1851
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||||||||||||||||
| name: test season pass | ||||||||||||||||||
|
|
||||||||||||||||||
| on: | ||||||||||||||||||
| pull_request: | ||||||||||||||||||
| paths-ignore: | ||||||||||||||||||
| - "contracts/**" | ||||||||||||||||||
| - "client/**" | ||||||||||||||||||
| - "**/manifest.json" | ||||||||||||||||||
| - "discord-bot/**" | ||||||||||||||||||
| - "config/**" | ||||||||||||||||||
| - ".github/**" | ||||||||||||||||||
| - "pnpm-lock.yaml" | ||||||||||||||||||
|
|
||||||||||||||||||
| env: | ||||||||||||||||||
| SCARB_VERSION: v2.8.2 | ||||||||||||||||||
|
Comment on lines
+14
to
+15
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider using the SCARB_VERSION environment variable. The Update the Scarb setup step to use the environment variable: - uses: software-mansion/setup-scarb@v1
with:
+ scarb-version: ${{ env.SCARB_VERSION }}
tool-versions: season_pass/contracts/.tool-versions📝 Committable suggestion
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| jobs: | ||||||||||||||||||
| test-season-pass: | ||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - uses: actions/checkout@v3 | ||||||||||||||||||
| - uses: software-mansion/setup-scarb@v1 | ||||||||||||||||||
| with: | ||||||||||||||||||
| tool-versions: season_pass/contracts/.tool-versions | ||||||||||||||||||
| - uses: foundry-rs/setup-snfoundry@v3 | ||||||||||||||||||
| with: | ||||||||||||||||||
| tool-versions: season_pass/contracts/.tool-versions | ||||||||||||||||||
|
Comment on lines
+17
to
+27
There was a problem hiding this comment. 💡 Codebase verification 🛠️ Refactor suggestion Update actions and pin the Ubuntu version. The current workflow uses
🔗 Analysis chainConsider updating actions and pinning the Ubuntu version. The job setup looks good overall, but there are a few suggestions for improvement:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- runs-on: ubuntu-latest
+ runs-on: ubuntu-22.04
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the existence and content of the .tool-versions file
# Test: Check if the file exists and display its content
if [ -f "season_pass/contracts/.tool-versions" ]; then
echo "Content of .tool-versions file:"
cat "season_pass/contracts/.tool-versions"
else
echo "Error: .tool-versions file not found"
exit 1
fi
Length of output: 201 Script: #!/bin/bash
# Description: Check the version of actions/checkout in the workflow file
# Use grep to find the actions/checkout version
echo "Checking actions/checkout version:"
grep 'uses: actions/checkout@' .github/workflows/test-season-pass.yml || { echo "actions/checkout not found"; exit 1; }
Length of output: 184 Script: #!/bin/bash
# Description: Verify if the Ubuntu version is pinned in the workflow file
# Check if runs-on is set to ubuntu-latest
echo "Checking runs-on configuration:"
if grep -q 'runs-on: ubuntu-latest' .github/workflows/test-season-pass.yml; then
echo "runs-on is set to ubuntu-latest. Consider pinning to a specific version like ubuntu-22.04."
exit 1
else
echo "runs-on is pinned to a specific Ubuntu version."
fi
Length of output: 346 |
||||||||||||||||||
| - run: scarb build | ||||||||||||||||||
| working-directory: season_pass/contracts | ||||||||||||||||||
| - run: snforge test | ||||||||||||||||||
| working-directory: season_pass/contracts | ||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| node_modules | ||
| target | ||
| .snfoundry_cache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| scarb 2.8.4 | ||
| dojo 1.0.0-rc.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,12 @@ | |
| "strict": true, | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
|
|
||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@/*": ["./src/*"] | ||
| } | ||
| }, | ||
| "include": ["src"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| VITE_PUBLIC_MASTER_ADDRESS="0x1a3e37c77be7de91a9177c6b57956faa6da25607e567b10a25cf64fea5e533b" | ||
| VITE_PUBLIC_MASTER_PRIVATE_KEY="0x4ab5a607d92f0870cfd82ef9cecb2fe903830441180fd432b831a8863c08097" | ||
| VITE_PUBLIC_WORLD_ADDRESS="0x073bad29b5c12b09f9023e8d3a5876ea6ebd41fa26cab5035369fec4691067c2" | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH="0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" | ||
| VITE_EVENT_KEY="0x1a2f334228cee715f1f0f54053bb6b5eac54fa336e0bc1aacf7516decb0471d" | ||
| VITE_PUBLIC_TORII="https://api.cartridge.gg/x/eternum-42/torii" | ||
| VITE_PUBLIC_NODE_URL="https://api.cartridge.gg/x/eternum-42/katana/" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| VITE_PUBLIC_MASTER_ADDRESS=0x4aa20bd71961247515f78970708f260c60b308e4ae131f085a6f5a61d0f19c0 | ||
| VITE_PUBLIC_MASTER_PRIVATE_KEY=0x1957b6ac5c9f80cb18995c3304e63b2a8dd33c1e058c2f014de0b4c5c788fd | ||
| VITE_PUBLIC_WORLD_ADDRESS="0x073bad29b5c12b09f9023e8d3a5876ea6ebd41fa26cab5035369fec4691067c2" | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH="0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" | ||
| VITE_PUBLIC_TORII=https://api.cartridge.gg/x/eternum-rc1-1/torii | ||
| VITE_PUBLIC_NODE_URL=https://api.cartridge.gg/x/eternum-rc1-1/katana | ||
| VITE_PUBLIC_DEV=false | ||
| VITE_PUBLIC_GAME_VERSION="v1.0.0-rc0" | ||
| VITE_PUBLIC_SHOW_FPS=false | ||
| VITE_PUBLIC_GRAPHICS_DEV=false | ||
| VITE_PUBLIC_TORII_RELAY=/dns4/api.cartridge.gg/tcp/443/x-parity-wss/%2Fx%2Feternum-rc1-1%2Ftorii%2Fwss | ||
|
|
||
| VITE_SEASON_PASS_ADDRESS="0x4ba954b600d68b3309f0f9a6a1626389ca1a3615bdaef754e9f04b07ca0b62d" | ||
| VITE_REALMS_ADDRESS="0x6b9857a356258e95a7ad7c842ca4cc71c25e171b123256072d2abefef2e03ec" | ||
| VITE_LORDS_ADDRESS="0x4ca3786b2bbe3c9b373b19f6c5b27bc5cfa9ed169292583b126c2fd9ee27200" | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| VITE_PUBLIC_MASTER_ADDRESS="0x127fd5f1fe78a71f8bcd1fec63e3fe2f0486b6ecd5c86a0466c3a21fa5cfcec" | ||
| VITE_PUBLIC_MASTER_PRIVATE_KEY="0xc5b2fcab997346f3ea1c00b002ecf6f382c5f9c9659a3894eb783c5320f912" | ||
| VITE_PUBLIC_WORLD_ADDRESS="0x073bad29b5c12b09f9023e8d3a5876ea6ebd41fa26cab5035369fec4691067c2" | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH="0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" | ||
| VITE_NETWORK_FEE_TOKEN="0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7" | ||
| VITE_EVENT_KEY="0x1a2f334228cee715f1f0f54053bb6b5eac54fa336e0bc1aacf7516decb0471d" | ||
| VITE_PUBLIC_TORII="http://localhost:8080" | ||
|
|
@@ -12,5 +12,9 @@ VITE_PUBLIC_DEV=false | |
| VITE_PUBLIC_SHOW_FPS=true | ||
| VITE_PUBLIC_GRAPHICS_DEV=false | ||
|
|
||
| VITE_SEASON_PASS_ADDRESS="0x18cd31a545b13597adeafa40979a7456aae9d12bd0b9a9879089ed051402c6c" | ||
| VITE_REALMS_ADDRESS="0x57e1cb22f5688a833ceff37d8569297877dd8fc1896e36f1a0c8b2d30b7de85" | ||
| VITE_LORDS_ADDRESS="0x5839f41cadbe12678b2e7b67bd6daa5bd54b7b19bdc835c87fe4662dbf7a93c" | ||
|
|
||
| # You will have to change this to your local torii. It will be in the printout. | ||
| VITE_PUBLIC_TORII_RELAY="/ip4/0.0.0.0/udp/9091/webrtc-direct/certhash/uEiAN3-ttwg-yphp9ZgqhSCGNsWLXIo0eHEsrLRUzp4SpKg" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -149,7 +149,7 @@ Procfile text | |
| *.wbmp binary | ||
| *.webp binary | ||
| *.avif binary | ||
| *.hdr binary | ||
|
|
||
| # Audio | ||
| *.kar binary | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,4 +22,6 @@ dist-ssr | |
| *.njsproj | ||
| *.sln | ||
| *.sw? | ||
| yarn.lock | ||
|
|
||
| dev-dist | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import { createDojoConfig } from "@dojoengine/core"; | ||
| import devManifest from "../contracts/manifest_dev.json"; | ||
| import productionManifest from "../contracts/manifest_prod.json"; | ||
|
|
||
| const { | ||
| VITE_PUBLIC_NODE_URL, | ||
|
|
@@ -15,14 +15,16 @@ const { | |
|
|
||
| const manifest = VITE_PUBLIC_DEV === "true" ? devManifest : productionManifest; | ||
|
|
||
| console.log(productionManifest); | ||
|
|
||
| export const dojoConfig = createDojoConfig({ | ||
| rpcUrl: VITE_PUBLIC_NODE_URL, | ||
| toriiUrl: VITE_PUBLIC_TORII, | ||
| relayUrl: VITE_PUBLIC_TORII_RELAY, | ||
| masterAddress: VITE_PUBLIC_MASTER_ADDRESS, | ||
| masterPrivateKey: VITE_PUBLIC_MASTER_PRIVATE_KEY, | ||
| accountClassHash: | ||
| VITE_PUBLIC_ACCOUNT_CLASS_HASH || "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2", | ||
|
There was a problem hiding this comment. 💡 Codebase verification Inconsistent
🔗 Analysis chainVerify the new account class hash across the codebase. The To ensure consistency and correctness, please run the following script: Ensure that:
If any inconsistencies are found, please update the relevant files to maintain consistency across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the new account class hash across the codebase
# Test 1: Check for the new hash in .env files
echo "Checking .env files for the new hash:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" .env*
# Test 2: Check for any remaining instances of the old hash
echo "Checking for any remaining instances of the old hash:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c"
# Test 3: Verify VITE_PUBLIC_ACCOUNT_CLASS_HASH in .env files
echo "Verifying VITE_PUBLIC_ACCOUNT_CLASS_HASH in .env files:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" .env*
Length of output: 610 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase
# Test 1: Check for the new hash in all files
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --ignore-dir={node_modules,dist,build}
# Test 2: Check for any remaining instances of the old hash in all files
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --ignore-dir={node_modules,dist,build}
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --ignore-dir={node_modules,dist,build}
Length of output: 2187 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase with corrected rg commands
# Test 1: Check for the new hash in all files
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
# Test 2: Check for any remaining instances of the old account class hash in all files
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --ignore-dir node_modules --ignore-dir dist --ignore-dir build
Length of output: 2187 Script: #!/bin/bash
# Description: Comprehensive verification of the account class hash across the entire codebase using --glob to exclude directories
# Test 1: Check for the new account class hash in all files except excluded directories
echo "Checking for the new account class hash in the codebase:"
rg "0x07dc7899aa655b0aae51eadff6d801a58e97dd99cf4666ee59e704249e51adf2" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
# Test 2: Check for any remaining instances of the old account class hash in all files except excluded directories
echo "Checking for any remaining instances of the old account class hash in the codebase:"
rg "0x05400e90f7e0ae78bd02c77cd75527280470e2fe19c54970dd79dc37a9d3645c" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
# Test 3: Verify all instances of VITE_PUBLIC_ACCOUNT_CLASS_HASH are updated in all files except excluded directories
echo "Verifying all occurrences of VITE_PUBLIC_ACCOUNT_CLASS_HASH in the codebase:"
rg "VITE_PUBLIC_ACCOUNT_CLASS_HASH" --hidden --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**'
Length of output: 2251 |
||
| feeTokenAddress: VITE_PUBLIC_FEE_TOKEN_ADDRESS || "0x0", | ||
| manifest, | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,12 +40,17 @@ | |
| <link rel="prefetch" href="/images/resources/9.png" /> | ||
| <link rel="prefetch" href="/images/resources/coin.png" /> | ||
| <!-- avatars --> | ||
| <link rel="prefetch" href="/images/avatars/01.png" /> | ||
| <link rel="prefetch" href="/images/avatars/02.png" /> | ||
| <link rel="prefetch" href="/images/avatars/03.png" /> | ||
| <link rel="prefetch" href="/images/avatars/04.png" /> | ||
| <link rel="prefetch" href="/images/avatars/05.png" /> | ||
| <link rel="prefetch" href="/images/avatars/06.png" /> | ||
| <link rel="prefetch" href="/images/avatars/07.png" /> | ||
| <link rel="prefetch" href="/images/avatars/08.png" /> | ||
| <link rel="prefetch" href="/images/avatars/09.png" /> | ||
| <link rel="prefetch" href="/images/avatars/10.png" /> | ||
|
|
||
| <!-- buildings --> | ||
| <!-- contruction --> | ||
| <link rel="prefetch" href="/images/buildings/construction/archery.png" /> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,12 +40,17 @@ | |
| <link rel="prefetch" href="/images/resources/9.png" /> | ||
| <link rel="prefetch" href="/images/resources/coin.png" /> | ||
| <!-- avatars --> | ||
| <link rel="prefetch" href="/images/avatars/01.png" /> | ||
| <link rel="prefetch" href="/images/avatars/02.png" /> | ||
| <link rel="prefetch" href="/images/avatars/03.png" /> | ||
| <link rel="prefetch" href="/images/avatars/04.png" /> | ||
| <link rel="prefetch" href="/images/avatars/05.png" /> | ||
| <link rel="prefetch" href="/images/avatars/06.png" /> | ||
| <link rel="prefetch" href="/images/avatars/07.png" /> | ||
| <link rel="prefetch" href="/images/avatars/08.png" /> | ||
| <link rel="prefetch" href="/images/avatars/09.png" /> | ||
| <link rel="prefetch" href="/images/avatars/10.png" /> | ||
|
|
||
| <!-- buildings --> | ||
| <!-- contruction --> | ||
| <link rel="prefetch" href="/images/buildings/construction/archery.png" /> | ||
|
|
@@ -77,6 +82,17 @@ | |
| <link rel="prefetch" href="/textures/paper/worldmap-bg.png" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | ||
| <title>Realms: Eternum</title> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1" /> | ||
|
There was a problem hiding this comment. Remove duplicate viewport meta tag. There's a conflicting viewport meta tag. The existing tag prevents zooming with |
||
| <meta name="description" content="The ultimate strategy game on Starknet" /> | ||
| <meta property="og:title" content="Realms: Eternum" /> | ||
| <meta property="og:description" content="The ultimate strategy game on Starknet" /> | ||
| <meta property="og:image" content="/images/cover.png" /> | ||
| <meta property="og:url" content="https://eternum.realms.world" /> | ||
| <meta property="og:type" content="website" /> | ||
| <link rel="icon" href="/images/favicon.ico" /> | ||
| <link rel="apple-touch-icon" href="/images/apple-touch-icon-180x180.png" sizes="180x180" /> | ||
| <link rel="mask-icon" href="/images/maskable-icon-512x512.png" color="#FFFFFF" /> | ||
| <meta name="theme-color" content="#ffffff" /> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,12 +40,17 @@ | |
| <link rel="prefetch" href="/images/resources/9.png" /> | ||
| <link rel="prefetch" href="/images/resources/coin.png" /> | ||
| <!-- avatars --> | ||
| <link rel="prefetch" href="/images/avatars/01.png" /> | ||
| <link rel="prefetch" href="/images/avatars/02.png" /> | ||
| <link rel="prefetch" href="/images/avatars/03.png" /> | ||
| <link rel="prefetch" href="/images/avatars/04.png" /> | ||
| <link rel="prefetch" href="/images/avatars/05.png" /> | ||
| <link rel="prefetch" href="/images/avatars/06.png" /> | ||
| <link rel="prefetch" href="/images/avatars/07.png" /> | ||
| <link rel="prefetch" href="/images/avatars/08.png" /> | ||
| <link rel="prefetch" href="/images/avatars/09.png" /> | ||
| <link rel="prefetch" href="/images/avatars/10.png" /> | ||
|
Comment on lines
+43
to
+52
There was a problem hiding this comment. 💡 Codebase verification The prefetch links reference avatar images that don't exist in the expected location. Additionally, there are dynamic avatar references in the codebase that might need adjustment:
Please ensure:
🔗 Analysis chainLGTM! Improved avatar naming convention. The update to a two-digit format (01-10) provides better consistency and sorting. The expansion from 6 to 10 avatars suggests enhanced customization options. Let's verify the existence of the new avatar images and check for any remaining old-format references: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify avatar images and references
# Test 1: Check if all new avatar images exist
for i in {01..10}; do
fd "^${i}.png$" "images/avatars"
done
# Test 2: Look for any remaining single-digit avatar references that might need updating
rg -g '!*.html' '[^0-9][1-6]\.png'
# Test 3: Check for any hardcoded avatar paths that might need updating
ast-grep --pattern 'avatars/[1-6].png'
Length of output: 3281 Script: #!/bin/bash
# Let's verify if the images directory exists and its structure
fd -t d "images"
# Check for any avatar-related files in the repository
fd -t f "avatar"
# Look for any references to avatar images in the codebase
rg -g '!*.html' "avatar.*\.png"
Length of output: 641 |
||
|
|
||
| <!-- buildings --> | ||
| <!-- contruction --> | ||
| <link rel="prefetch" href="/images/buildings/construction/archery.png" /> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Test matrix entries don't match actual test file names
The workflow's test matrix entries don't correspond to the actual test file structure in the repository. The test files are organized as:
contracts/src/systems/resources/tests/resource_bridge_system_tests.cairocontracts/src/systems/trade/tests/trade_systems_tests.cairocontracts/src/systems/realm/tests.cairocontracts/src/systems/guild/tests.cairocontracts/src/systems/transport/tests/travel_systems_tests.cairocontracts/src/systems/ownership/tests.cairoThe matrix entries should be updated to match these actual file names and paths.
🔗 Analysis chain
Maintain consistent test naming conventions.
The test name
test_ownership_systemsdoesn't follow the*_testnaming pattern used by other tests in the matrix.Consider renaming to
ownership_systems_testfor consistency.Let's verify the test files exist and follow naming conventions:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 279
Script:
Length of output: 2824