Repository navigation
docs(azure-sentinel): allow DCE logs ingestion URI for AZURE_SENTINEL_ENDPOINT - #3199
Merged
Merged
Conversation
…_ENDPOINT Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The Azure Sentinel page said
AZURE_SENTINEL_ENDPOINTmust be the DCR logs ingestion endpoint and "NOT the Data Collection Endpoint (DCE)". That is wrong. The Logs Ingestion API takes either one with the same{endpoint}/dataCollectionRules/{dcrImmutableId}/streams/{streamName}URI (Microsoft docs), and theazure_sentinelcallback builds exactly that URI in_build_api_endpoint. A Microsoft Sentinel CCF Push connector hands users a DCE URI, so the page now says both work.Files changed
docs/observability/azure_sentinel.mdLinear ticket
Resolves LIT-11043
Screenshots / Proof of Fix
Docs-only change, so the proof is the rendered page from
npx docusaurus startat this commit.python3 scripts/check-docs.pyreports no structural problems, andnode scripts/check-writing-style.js docs/observability/azure_sentinel.mdreports no em dashes.Details
Link to Devin session: https://app.devin.ai/sessions/bea86ed8da294c74b87752c26bf1a893
Open in Devin Desktop: https://app.devin.ai/desktop/session/bea86ed8da294c74b87752c26bf1a893?variant=devin
Requested by: @yassin-berriai