Repository navigation
docs(azure_sentinel): explain where to find the DCE and DCR logs ingestion endpoints - #3202
Open
yassin-berriai wants to merge 2 commits into
Open
yassin-berriai wants to merge 2 commits into
yassin-berriai wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@litereview code-review |
…ntinel_dce_endpoint Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # docs/observability/azure_sentinel.md
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
#3199 already corrected the "NOT the DCE" claim on the Azure Sentinel page. This PR adds what that change left out, which is where to find each endpoint and when a DCE is required. The Logs Ingestion API accepts either endpoint with the same URI, and the
azure_sentinelcallback builds that URI from whatever endpoint it is givenLinear ticket
Resolves LIT-11043
Files changed
docs/observability/azure_sentinel.mdproperties.endpoints.logsIngestionin JSON view) and the DCE endpoint (Monitor -> Data Collection Endpoints -> Overview -> Logs Ingestion), when a DCE is required (private link, or a DCR without its own logs ingestion endpoint) and that all three resources must share a region. The portal walkthrough step that copies the endpoint also points at the DCE selected in Step 3The code side was checked on litellm main.
AzureSentinelLogger._build_api_endpointinlitellm/integrations/azure_sentinel/azure_sentinel.pyreturnsf"{endpoint.rstrip('/')}/dataCollectionRules/{dcr_immutable_id}/streams/{stream_name}?api-version=2023-01-01"with no check on the endpoint type, and the constructor docstring already says the endpoint is a "Data Collection Endpoint (DCE) or DCR ingestion endpoint"Screenshots / Proof of Fix
npm run buildandpython3 scripts/check-docs.pypass locally. Rendered page from the local production build of the merged tip (on top of #3199):Details
Link to Devin session: https://app.devin.ai/sessions/f609b01e9c6a4553ac0570653793a6af
Open in Devin Desktop: https://app.devin.ai/desktop/session/f609b01e9c6a4553ac0570653793a6af?variant=devin
Requested by: @yassin-berriai